From: Christoph Hellwig <hch@infradead.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
James Bottomley <JBottomley@odin.com>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Hannes Reinecke <hare@suse.de>,
Matthew Wilcox <willy@linux.intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH, resend] scsi: advansys: fix big-endian builds
Date: Mon, 16 Nov 2015 10:35:01 -0800 [thread overview]
Message-ID: <20151116183501.GA25744@infradead.org> (raw)
In-Reply-To: <20151116182031.GX8644@n2100.arm.linux.org.uk>
On Mon, Nov 16, 2015 at 06:20:31PM +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
> > It turns out that the commit that introduced this used the cpu_to_le32()
> > incorrectly on an 8-bit field, which results in the sense_len to always
> > be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper
> > byte of the 32-bit intermediate.
>
> More people need to run the sparse checker with -D__CHECK_ENDIAN__ and
> have proper endian annotations?
Ho about enabling __CHECK_ENDIAN__ by default when running sparse at
least?
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH, resend] scsi: advansys: fix big-endian builds
Date: Mon, 16 Nov 2015 10:35:01 -0800 [thread overview]
Message-ID: <20151116183501.GA25744@infradead.org> (raw)
In-Reply-To: <20151116182031.GX8644@n2100.arm.linux.org.uk>
On Mon, Nov 16, 2015 at 06:20:31PM +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
> > It turns out that the commit that introduced this used the cpu_to_le32()
> > incorrectly on an 8-bit field, which results in the sense_len to always
> > be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper
> > byte of the 32-bit intermediate.
>
> More people need to run the sparse checker with -D__CHECK_ENDIAN__ and
> have proper endian annotations?
Ho about enabling __CHECK_ENDIAN__ by default when running sparse at
least?
next prev parent reply other threads:[~2015-11-16 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 16:49 [PATCH, resend] scsi: advansys: fix big-endian builds Arnd Bergmann
2015-11-16 16:49 ` Arnd Bergmann
2015-11-16 18:20 ` Russell King - ARM Linux
2015-11-16 18:20 ` Russell King - ARM Linux
2015-11-16 18:35 ` Christoph Hellwig [this message]
2015-11-16 18:35 ` Christoph Hellwig
2015-11-16 18:56 ` Geert Uytterhoeven
2015-11-16 18:56 ` Geert Uytterhoeven
2015-11-17 6:46 ` Hannes Reinecke
2015-11-17 6:46 ` Hannes Reinecke
2015-11-18 15:18 ` Martin K. Petersen
2015-11-18 15:18 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116183501.GA25744@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@odin.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=hare@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=martin.petersen@oracle.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.