All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Chris Mason <clm@fb.com>, Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: clone ioctl return values
Date: Tue, 17 Nov 2015 07:22:52 -0800	[thread overview]
Message-ID: <20151117152251.GA5392@infradead.org> (raw)
In-Reply-To: <20151117135745.GF17545@ret.masoncoding.com>

On Tue, Nov 17, 2015 at 08:57:45AM -0500, Chris Mason wrote:
> > > Errrgh, the golden output of this test reflects the changes to the input
> > > checking in Anna/Peng's copy_file_range/clone_file_range patches.
> > > 
> > > So, I guess the question is, should I reset the golden output to whatever
> > > btrfs spits out before that patchset, and we'll consider the alterations
> > > to be bugs/regressions/whatever that ought to be fixed in their patches?
> > 
> > Some bits in btrfs don't seem kosher.  But it would be good to
> > explicitly send patches for btrfs to adopt to what might make more
> > sense, and then follow it in the other implementations.
> 
> Btrfs does check for directories, but we should really be checking for
> regular files too.  In the end, we only copy extents that would
> correspond with regular files, so we're sneaking by.

Yes, I saw that.  So so far I'd suggest something like the following
for btrfs:

 - return EBADFD for missing read/wite permissions
 - return EINVAL for wrong non-directory file types as the
   source fd

And then make the test case and other implementations match this.

Does this sound like a plan?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Chris Mason <clm@fb.com>, Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: clone ioctl return values
Date: Tue, 17 Nov 2015 07:22:52 -0800	[thread overview]
Message-ID: <20151117152251.GA5392@infradead.org> (raw)
In-Reply-To: <20151117135745.GF17545@ret.masoncoding.com>

On Tue, Nov 17, 2015 at 08:57:45AM -0500, Chris Mason wrote:
> > > Errrgh, the golden output of this test reflects the changes to the input
> > > checking in Anna/Peng's copy_file_range/clone_file_range patches.
> > > 
> > > So, I guess the question is, should I reset the golden output to whatever
> > > btrfs spits out before that patchset, and we'll consider the alterations
> > > to be bugs/regressions/whatever that ought to be fixed in their patches?
> > 
> > Some bits in btrfs don't seem kosher.  But it would be good to
> > explicitly send patches for btrfs to adopt to what might make more
> > sense, and then follow it in the other implementations.
> 
> Btrfs does check for directories, but we should really be checking for
> regular files too.  In the end, we only copy extents that would
> correspond with regular files, so we're sneaking by.

Yes, I saw that.  So so far I'd suggest something like the following
for btrfs:

 - return EBADFD for missing read/wite permissions
 - return EINVAL for wrong non-directory file types as the
   source fd

And then make the test case and other implementations match this.

Does this sound like a plan?

  reply	other threads:[~2015-11-17 15:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 12:04 clone ioctl return values Christoph Hellwig
2015-11-16 12:04 ` Christoph Hellwig
2015-11-17  0:28 ` Darrick J. Wong
2015-11-17  0:28   ` Darrick J. Wong
2015-11-17 10:54   ` Christoph Hellwig
2015-11-17 10:54     ` Christoph Hellwig
2015-11-17 13:57     ` Chris Mason
2015-11-17 13:57       ` Chris Mason
2015-11-17 15:22       ` Christoph Hellwig [this message]
2015-11-17 15:22         ` Christoph Hellwig
2015-11-17 15:33         ` Al Viro
2015-11-17 15:33           ` Al Viro
2015-11-17 15:36           ` Christoph Hellwig
2015-11-17 15:36             ` Christoph Hellwig
2015-11-17 18:42         ` Chris Mason
2015-11-17 18:42           ` Chris Mason
2015-11-18  3:01         ` Darrick J. Wong
2015-11-18  3:01           ` Darrick J. Wong
2015-11-18 15:11           ` Christoph Hellwig
2015-11-18 15:11             ` Christoph Hellwig
2015-11-17 15:12   ` Christoph Hellwig
2015-11-17 15:12     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151117152251.GA5392@infradead.org \
    --to=hch@infradead.org \
    --cc=clm@fb.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.