From: Brian Norris <computersforpeace@gmail.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Marek Vasut <marex@denx.de>, Michal Suchanek <hramrach@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices
Date: Tue, 17 Nov 2015 09:48:56 -0800 [thread overview]
Message-ID: <20151117174856.GB8456@google.com> (raw)
In-Reply-To: <564AC9FD.6090909@ti.com>
Hi,
On Tue, Nov 17, 2015 at 12:02:29PM +0530, Vignesh R wrote:
> On 11/13/2015 09:35 PM, Cyrille Pitchen wrote:
> >
> > In September I've sent a series of patches to enhance the support of QSPI flash
> > memories. Patch 4 was dedicated to the m25p80 driver and set the
> > rx_nbits / tx_nbits fields of spi_transfer struct(s) in order to configure the
> > number of I/O lines independently for the opcode, address and data parts.
> > The work was done for m25p80_read() but also for _read_reg(), _write_reg() and
> > _write().
> > The patched m25p80 driver was then tested with an at25 memory to check non-
> > regression.
> >
> > This series of patches also added 4 enum spi_protocol fields inside struct
> > spi_nor so the spi-nor framework can tell the (Q)SPI controller driver what SPI
> > protocol should be use for erase, read, write and register read/write
> > operations, depending on the memory manufacturer and the command opcode.
> > This was done to better support Micron, Spansion and Macronix QSPI memories.
> >
> > I have tested the series with Micron QSPI memories and Atmel QSPI controller
> > and I guess Marek also tested it on his side with Spansion QSPI memories and
> > another QSPI controller.
> >
> > So if it can help other developers to develop QSPI controller drivers, the
> > series is still available there:
> >
> > for the whole series:
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/371170.html
> >
> > for patch 4 (depends on patch 2 for enum spi_protocol):
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/371173.html
> >
>
> Should I rebase my next version on top of above patches by Cyrille or
> shall I post on top of 4.4-rc1?
I'm sorry to say I really haven't had the time to review that properly.
I'm also not sure it is a true dependency for your series, as you're
tackling different pieces of the puzzle. So it's mostly just a conflict,
not a real direct help.
So unless I'm misunderstanding, I'd suggest submitting MTD stuff against
the latest l2-mtd.git (or linux-next.git; l2-mtd.git is included there),
and I'll let you know if conflicts come up that need fixing.
Brian
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices
Date: Tue, 17 Nov 2015 09:48:56 -0800 [thread overview]
Message-ID: <20151117174856.GB8456@google.com> (raw)
In-Reply-To: <564AC9FD.6090909@ti.com>
Hi,
On Tue, Nov 17, 2015 at 12:02:29PM +0530, Vignesh R wrote:
> On 11/13/2015 09:35 PM, Cyrille Pitchen wrote:
> >
> > In September I've sent a series of patches to enhance the support of QSPI flash
> > memories. Patch 4 was dedicated to the m25p80 driver and set the
> > rx_nbits / tx_nbits fields of spi_transfer struct(s) in order to configure the
> > number of I/O lines independently for the opcode, address and data parts.
> > The work was done for m25p80_read() but also for _read_reg(), _write_reg() and
> > _write().
> > The patched m25p80 driver was then tested with an at25 memory to check non-
> > regression.
> >
> > This series of patches also added 4 enum spi_protocol fields inside struct
> > spi_nor so the spi-nor framework can tell the (Q)SPI controller driver what SPI
> > protocol should be use for erase, read, write and register read/write
> > operations, depending on the memory manufacturer and the command opcode.
> > This was done to better support Micron, Spansion and Macronix QSPI memories.
> >
> > I have tested the series with Micron QSPI memories and Atmel QSPI controller
> > and I guess Marek also tested it on his side with Spansion QSPI memories and
> > another QSPI controller.
> >
> > So if it can help other developers to develop QSPI controller drivers, the
> > series is still available there:
> >
> > for the whole series:
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/371170.html
> >
> > for patch 4 (depends on patch 2 for enum spi_protocol):
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/371173.html
> >
>
> Should I rebase my next version on top of above patches by Cyrille or
> shall I post on top of 4.4-rc1?
I'm sorry to say I really haven't had the time to review that properly.
I'm also not sure it is a true dependency for your series, as you're
tackling different pieces of the puzzle. So it's mostly just a conflict,
not a real direct help.
So unless I'm misunderstanding, I'd suggest submitting MTD stuff against
the latest l2-mtd.git (or linux-next.git; l2-mtd.git is included there),
and I'll let you know if conflicts come up that need fixing.
Brian
next prev parent reply other threads:[~2015-11-17 17:48 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 5:29 [PATCH v3 0/5] Add memory mapped read support for ti-qspi Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 23:23 ` Brian Norris
2015-11-10 23:23 ` Brian Norris
2015-11-10 23:23 ` Brian Norris
2015-11-11 6:50 ` R, Vignesh
2015-11-11 6:50 ` R, Vignesh
2015-11-11 6:50 ` R, Vignesh
2015-11-11 7:20 ` Brian Norris
2015-11-11 7:20 ` Brian Norris
2015-11-11 7:20 ` Brian Norris
2015-11-13 16:05 ` Cyrille Pitchen
2015-11-13 16:05 ` Cyrille Pitchen
2015-11-13 16:05 ` Cyrille Pitchen
2015-11-13 16:05 ` Cyrille Pitchen
2015-11-17 6:32 ` Vignesh R
2015-11-17 6:32 ` Vignesh R
2015-11-17 6:32 ` Vignesh R
2015-11-17 6:32 ` Vignesh R
2015-11-17 17:48 ` Brian Norris [this message]
2015-11-17 17:48 ` Brian Norris
2015-11-13 14:06 ` Mike Looijmans
2015-11-13 14:06 ` Mike Looijmans
2015-11-13 14:06 ` Mike Looijmans
2015-11-11 19:24 ` Brian Norris
2015-11-11 19:24 ` Brian Norris
2015-11-11 19:24 ` Brian Norris
2015-11-12 4:32 ` Vignesh R
2015-11-12 4:32 ` Vignesh R
2015-11-10 5:29 ` [PATCH v3 2/5] spi: spi-ti-qspi: add mmap mode read support Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` [PATCH v3 3/5] mtd: devices: m25p80: add support for mmap read request Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` [PATCH v3 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` [PATCH v3 5/5] ARM: dts: AM4372: " Vignesh R
2015-11-10 5:29 ` Vignesh R
2015-11-10 5:29 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117174856.GB8456@google.com \
--to=computersforpeace@gmail.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=hramrach@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marex@denx.de \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.