From: Vinod Koul <vinod.koul@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Jie Yang <yang.jie@intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()
Date: Wed, 18 Nov 2015 23:52:50 +0530 [thread overview]
Message-ID: <20151118182249.GY25173@localhost> (raw)
In-Reply-To: <20151118100255.GA15236@mwanda>
On Wed, Nov 18, 2015 at 01:04:20PM +0300, Dan Carpenter wrote:
> "data" is always NULL in this function. I think we should be passing
> "&data" to sst_prepare_and_post_msg() instead of "data".
>
> Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
This looks right to me but this should have resulted in broken stuff, I will
test this tomorrow and get back
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Jie Yang <yang.jie@intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()
Date: Wed, 18 Nov 2015 18:34:50 +0000 [thread overview]
Message-ID: <20151118182249.GY25173@localhost> (raw)
In-Reply-To: <20151118100255.GA15236@mwanda>
On Wed, Nov 18, 2015 at 01:04:20PM +0300, Dan Carpenter wrote:
> "data" is always NULL in this function. I think we should be passing
> "&data" to sst_prepare_and_post_msg() instead of "data".
>
> Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
This looks right to me but this should have resulted in broken stuff, I will
test this tomorrow and get back
--
~Vinod
next prev parent reply other threads:[~2015-11-18 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 10:04 [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld() Dan Carpenter
2015-11-18 10:04 ` Dan Carpenter
2015-11-18 18:22 ` Vinod Koul [this message]
2015-11-18 18:34 ` Vinod Koul
2015-11-19 10:47 ` Vinod Koul
2015-11-19 10:50 ` Vinod Koul
2015-11-21 14:01 ` Applied "ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118182249.GY25173@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yang.jie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.