From: hch@lst.de (Christoph Hellwig)
Subject: [RFC PATCH 4/9] nvmet: add a controller "start" hook
Date: Fri, 20 Nov 2015 06:13:55 +0100 [thread overview]
Message-ID: <20151120051355.GA19405@lst.de> (raw)
In-Reply-To: <1447978868-17138-5-git-send-email-mlin@kernel.org>
On Thu, Nov 19, 2015@04:21:03PM -0800, Ming Lin wrote:
> #define NVMET_SUBSYS_NAME_LEN 256
> char subsys_name[NVMET_SUBSYS_NAME_LEN];
> +
> + void *opaque;
> + void (*start)(void *);
> };
Why can't vhost use container_of to get at the containing structure
similar to what the loop driver does?
In addition I think we'll eventually need an ops structure here,
but I can take care of that later.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lin <mlin@kernel.org>
Cc: Ming Lin <ming.l@ssi.samsung.com>,
qemu-devel@nongnu.org,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
virtualization@lists.linux-foundation.org,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [RFC PATCH 4/9] nvmet: add a controller "start" hook
Date: Fri, 20 Nov 2015 06:13:55 +0100 [thread overview]
Message-ID: <20151120051355.GA19405@lst.de> (raw)
In-Reply-To: <1447978868-17138-5-git-send-email-mlin@kernel.org>
On Thu, Nov 19, 2015 at 04:21:03PM -0800, Ming Lin wrote:
> #define NVMET_SUBSYS_NAME_LEN 256
> char subsys_name[NVMET_SUBSYS_NAME_LEN];
> +
> + void *opaque;
> + void (*start)(void *);
> };
Why can't vhost use container_of to get at the containing structure
similar to what the loop driver does?
In addition I think we'll eventually need an ops structure here,
but I can take care of that later.
next prev parent reply other threads:[~2015-11-20 5:13 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 0:20 [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target Ming Lin
2015-11-20 0:20 ` [Qemu-devel] " Ming Lin
2015-11-20 0:20 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 1/9] nvme-vhost: add initial commit Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 2/9] nvme-vhost: add basic ioctl handlers Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 3/9] nvme-vhost: add basic nvme bar read/write Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 4/9] nvmet: add a controller "start" hook Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 5:13 ` Christoph Hellwig [this message]
2015-11-20 5:13 ` [Qemu-devel] " Christoph Hellwig
2015-11-20 5:31 ` Ming Lin
2015-11-20 5:31 ` [Qemu-devel] " Ming Lin
2015-11-20 5:31 ` Ming Lin
2015-11-20 5:13 ` Christoph Hellwig
2015-11-20 0:21 ` [RFC PATCH 5/9] nvme-vhost: add controller "start" callback Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 6/9] nvmet: add a "parse_extra_admin_cmd" hook Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 7/9] nvme-vhost: add "parse_extra_admin_cmd" callback Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 8/9] nvme-vhost: add vhost memory helpers Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 0:21 ` [RFC PATCH 9/9] nvme-vhost: add nvme queue handlers Ming Lin
2015-11-20 0:21 ` [Qemu-devel] " Ming Lin
2015-11-20 0:21 ` Ming Lin
2015-11-20 5:16 ` [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target Christoph Hellwig
2015-11-20 5:16 ` Christoph Hellwig
2015-11-20 5:16 ` [Qemu-devel] " Christoph Hellwig
2015-11-20 5:33 ` Ming Lin
2015-11-20 5:33 ` [Qemu-devel] " Ming Lin
2015-11-20 5:33 ` Ming Lin
2015-11-21 13:11 ` Paolo Bonzini
2015-11-21 13:11 ` [Qemu-devel] " Paolo Bonzini
2015-11-23 8:17 ` Ming Lin
2015-11-23 8:17 ` [Qemu-devel] " Ming Lin
2015-11-23 8:17 ` Ming Lin
2015-11-23 14:14 ` Paolo Bonzini
2015-11-23 14:14 ` [Qemu-devel] " Paolo Bonzini
2015-11-23 14:14 ` Paolo Bonzini
2015-11-24 7:27 ` Ming Lin
2015-11-24 7:27 ` [Qemu-devel] " Ming Lin
2015-11-24 7:27 ` Ming Lin
2015-11-24 8:23 ` Ming Lin
2015-11-24 8:23 ` [Qemu-devel] " Ming Lin
2015-11-24 8:23 ` Ming Lin
2015-11-24 10:51 ` Paolo Bonzini
2015-11-24 10:51 ` [Qemu-devel] " Paolo Bonzini
2015-11-24 10:51 ` Paolo Bonzini
2015-11-24 19:25 ` Ming Lin
2015-11-24 19:25 ` [Qemu-devel] " Ming Lin
2015-11-24 19:25 ` Ming Lin
2015-11-25 11:27 ` Paolo Bonzini
2015-11-25 11:27 ` [Qemu-devel] " Paolo Bonzini
2015-11-25 11:27 ` Paolo Bonzini
2015-11-25 18:51 ` Ming Lin
2015-11-25 18:51 ` [Qemu-devel] " Ming Lin
2015-11-25 18:51 ` Ming Lin
2015-11-25 19:32 ` Paolo Bonzini
2015-11-25 19:32 ` [Qemu-devel] " Paolo Bonzini
2015-11-25 19:32 ` Paolo Bonzini
2015-11-30 23:20 ` Ming Lin
2015-11-30 23:20 ` [Qemu-devel] " Ming Lin
2015-11-30 23:20 ` Ming Lin
2015-12-01 16:02 ` Paolo Bonzini
2015-12-01 16:02 ` [Qemu-devel] " Paolo Bonzini
2015-12-01 16:02 ` Paolo Bonzini
2015-12-01 16:26 ` Ming Lin
2015-12-01 16:26 ` [Qemu-devel] " Ming Lin
2015-12-01 16:26 ` Ming Lin
2015-12-01 16:59 ` Paolo Bonzini
2015-12-01 16:59 ` [Qemu-devel] " Paolo Bonzini
2015-12-01 16:59 ` Paolo Bonzini
2015-12-02 5:13 ` Ming Lin
2015-12-02 5:13 ` [Qemu-devel] " Ming Lin
2015-12-02 5:13 ` Ming Lin
2015-12-02 10:07 ` Paolo Bonzini
2015-12-02 10:07 ` [Qemu-devel] " Paolo Bonzini
2015-12-02 10:07 ` Paolo Bonzini
2015-11-21 13:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120051355.GA19405@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.