All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Nava kishore Manne <nava.manne@xilinx.com>
Cc: Nava kishore Manne <navam@xilinx.com>,
	anirudh@xilinx.com, linux-kernel@vger.kernel.org,
	michal.simek@xilinx.com, linux-serial@vger.kernel.org,
	jslaby@suse.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] serial: xuartps: Spliting the ISR into smaller routines.
Date: Fri, 20 Nov 2015 06:43:48 -0800	[thread overview]
Message-ID: <20151120144348.GS32017@xsjsorenbubuntu> (raw)
In-Reply-To: <1448026478-22131-1-git-send-email-navam@xilinx.com>

On Fri, 2015-11-20 at 07:04PM +0530, Nava kishore Manne wrote:
> Breaking the single big ISR that has both Rx and Tx
> in a single function into smaller ones
> 
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> ---
> Changes for v2:
> 	--Splits up the ISR without any functional changes as suggested
> 	by Peter Hurley
> 
>  drivers/tty/serial/xilinx_uartps.c | 247 ++++++++++++++++++++-----------------
>  1 file changed, 135 insertions(+), 112 deletions(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 009e0db..2e1b0a8 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -172,6 +172,9 @@ struct cdns_uart {
>  #define to_cdns_uart(_nb) container_of(_nb, struct cdns_uart, \
>  		clk_rate_change_nb);
>  
> +static void cdns_uart_handle_tx(void *dev_id);
> +static void cdns_uart_handle_rx(void *dev_id, unsigned int isrstatus);

Can't you just move these functions here instead of adding prototypes
here? Also, this is likely to conflict with
https://lkml.org/lkml/2015/11/19/622

	Sören

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] serial: xuartps: Spliting the ISR into smaller routines.
Date: Fri, 20 Nov 2015 06:43:48 -0800	[thread overview]
Message-ID: <20151120144348.GS32017@xsjsorenbubuntu> (raw)
In-Reply-To: <1448026478-22131-1-git-send-email-navam@xilinx.com>

On Fri, 2015-11-20 at 07:04PM +0530, Nava kishore Manne wrote:
> Breaking the single big ISR that has both Rx and Tx
> in a single function into smaller ones
> 
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> ---
> Changes for v2:
> 	--Splits up the ISR without any functional changes as suggested
> 	by Peter Hurley
> 
>  drivers/tty/serial/xilinx_uartps.c | 247 ++++++++++++++++++++-----------------
>  1 file changed, 135 insertions(+), 112 deletions(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 009e0db..2e1b0a8 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -172,6 +172,9 @@ struct cdns_uart {
>  #define to_cdns_uart(_nb) container_of(_nb, struct cdns_uart, \
>  		clk_rate_change_nb);
>  
> +static void cdns_uart_handle_tx(void *dev_id);
> +static void cdns_uart_handle_rx(void *dev_id, unsigned int isrstatus);

Can't you just move these functions here instead of adding prototypes
here? Also, this is likely to conflict with
https://lkml.org/lkml/2015/11/19/622

	S?ren

WARNING: multiple messages have this Message-ID (diff)
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Nava kishore Manne <nava.manne@xilinx.com>
Cc: <jslaby@suse.com>, <michal.simek@xilinx.com>,
	<anirudh@xilinx.com>, <linux-serial@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Nava kishore Manne <navam@xilinx.com>
Subject: Re: [PATCH v2 1/3] serial: xuartps: Spliting the ISR into smaller routines.
Date: Fri, 20 Nov 2015 06:43:48 -0800	[thread overview]
Message-ID: <20151120144348.GS32017@xsjsorenbubuntu> (raw)
In-Reply-To: <1448026478-22131-1-git-send-email-navam@xilinx.com>

On Fri, 2015-11-20 at 07:04PM +0530, Nava kishore Manne wrote:
> Breaking the single big ISR that has both Rx and Tx
> in a single function into smaller ones
> 
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> ---
> Changes for v2:
> 	--Splits up the ISR without any functional changes as suggested
> 	by Peter Hurley
> 
>  drivers/tty/serial/xilinx_uartps.c | 247 ++++++++++++++++++++-----------------
>  1 file changed, 135 insertions(+), 112 deletions(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 009e0db..2e1b0a8 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -172,6 +172,9 @@ struct cdns_uart {
>  #define to_cdns_uart(_nb) container_of(_nb, struct cdns_uart, \
>  		clk_rate_change_nb);
>  
> +static void cdns_uart_handle_tx(void *dev_id);
> +static void cdns_uart_handle_rx(void *dev_id, unsigned int isrstatus);

Can't you just move these functions here instead of adding prototypes
here? Also, this is likely to conflict with
https://lkml.org/lkml/2015/11/19/622

	Sören

  parent reply	other threads:[~2015-11-20 14:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 13:34 [PATCH v2 1/3] serial: xuartps: Spliting the ISR into smaller routines Nava kishore Manne
2015-11-20 13:34 ` Nava kishore Manne
2015-11-20 13:34 ` Nava kishore Manne
2015-11-20 13:34 ` [PATCH v2 2/3] serial: xuartps: Rewrite the interrupt handling logic Nava kishore Manne
2015-11-20 13:34   ` Nava kishore Manne
2015-11-20 13:34   ` Nava kishore Manne
2015-11-20 13:34 ` [PATCH v2 3/3] serial: xuartps: Do not enable parity error interrupt Nava kishore Manne
2015-11-20 13:34   ` Nava kishore Manne
2015-11-20 13:34   ` Nava kishore Manne
2015-11-20 14:43 ` Sören Brinkmann [this message]
2015-11-20 14:43   ` [PATCH v2 1/3] serial: xuartps: Spliting the ISR into smaller routines Sören Brinkmann
2015-11-20 14:43   ` Sören Brinkmann
2015-12-02  5:32   ` Nava kishore Manne
2015-12-02  5:32     ` Nava kishore Manne
2015-12-02  5:32     ` Nava kishore Manne
2015-12-02 23:04     ` Peter Hurley
2015-12-02 23:04       ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151120144348.GS32017@xsjsorenbubuntu \
    --to=soren.brinkmann@xilinx.com \
    --cc=anirudh@xilinx.com \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=nava.manne@xilinx.com \
    --cc=navam@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.