* [patch] net/hsr: fix a warning message
@ 2015-11-21 10:34 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-11-21 10:34 UTC (permalink / raw)
To: Arvid Brodin; +Cc: David S. Miller, netdev, kernel-janitors
WARN_ON_ONCE() takes a condition, it doesn't take an error message. I
have converted this to WARN() instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
index 35a9788..c7d1adc 100644
--- a/net/hsr/hsr_device.c
+++ b/net/hsr/hsr_device.c
@@ -312,7 +312,7 @@ static void send_hsr_supervision_frame(struct hsr_port *master, u8 type)
return;
out:
- WARN_ON_ONCE("HSR: Could not send supervision frame\n");
+ WARN_ONCE(1, "HSR: Could not send supervision frame\n");
kfree_skb(skb);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] net/hsr: fix a warning message
@ 2015-11-21 10:34 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-11-21 10:34 UTC (permalink / raw)
To: Arvid Brodin; +Cc: David S. Miller, netdev, kernel-janitors
WARN_ON_ONCE() takes a condition, it doesn't take an error message. I
have converted this to WARN() instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
index 35a9788..c7d1adc 100644
--- a/net/hsr/hsr_device.c
+++ b/net/hsr/hsr_device.c
@@ -312,7 +312,7 @@ static void send_hsr_supervision_frame(struct hsr_port *master, u8 type)
return;
out:
- WARN_ON_ONCE("HSR: Could not send supervision frame\n");
+ WARN_ONCE(1, "HSR: Could not send supervision frame\n");
kfree_skb(skb);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] net/hsr: fix a warning message
2015-11-21 10:34 ` Dan Carpenter
@ 2015-11-23 19:56 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-11-23 19:56 UTC (permalink / raw)
To: dan.carpenter; +Cc: arvid.brodin, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 21 Nov 2015 13:34:12 +0300
> WARN_ON_ONCE() takes a condition, it doesn't take an error message. I
> have converted this to WARN() instead.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] net/hsr: fix a warning message
@ 2015-11-23 19:56 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-11-23 19:56 UTC (permalink / raw)
To: dan.carpenter; +Cc: arvid.brodin, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 21 Nov 2015 13:34:12 +0300
> WARN_ON_ONCE() takes a condition, it doesn't take an error message. I
> have converted this to WARN() instead.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-23 19:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-21 10:34 [patch] net/hsr: fix a warning message Dan Carpenter
2015-11-21 10:34 ` Dan Carpenter
2015-11-23 19:56 ` David Miller
2015-11-23 19:56 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.