compiling pktgen w/ DPDK 2.1.0 and master seems broken

compiling pktgen w/ DPDK 2.1.0 and master seems broken

[Matthew Hall]

Hello,

There are some really weird errors if you try to compile pktgen using DPDK 
2.1.0. No matter what I try, the logic in the DPDK external app *.mk files 
seems to mess up the value of RTE_OUTPUT.

I tried tracing through the *.mk and I found various places where it was set 
right and various places where it was set wrong but never narrowed it down to 
a more specific spot.

It appears to involve Makefiles in subdirs, and rte.extsubdir.mk, but I can't 
figure out what is happening.

Also, if I try compiling pktgen against master, then I get some new problems:

app/pktgen-stats.c:308:9: error: ibadcrc is deprecated [-Werror=deprecated-declarations]
app/pktgen-stats.c:309:9: error: ibadlen is deprecated [-Werror=deprecated-declarations]

What is the secret recipe people are using to get this thing to compile right? 
Did I miss something?

Matthew.

mhall@mvs-01:~/src/sdn_sensor/external/pktgen-dpdk$ export RTE_TARGET=x86_64-native-linuxapp-gcc
mhall@mvs-01:~/src/sdn_sensor/external/pktgen-dpdk$ export RTE_SDK=$(realpath ~/dpdk/)
mhall@mvs-01:~/src/sdn_sensor/external/pktgen-dpdk$ make V=1 SHELL="/bin/sh -x"
+ [ -d /home/mhall/src/sdn_sensor/external/pktgen-dpdk/lib/common/lib/common/x86_64-native-linuxapp-gcc/lib ]
+ cp -f wr_copyright_info.o wr_port_config.o wr_core_info.o wr_lscpu.o wr_utils.o wr_coremap.o wr_pcap.o wr_cksum.o wr_l2p.o wr_scrn.o /home/mhall/src/sdn_sensor/external/pktgen-dpdk/lib/common/lib/common/x86_64-native-linuxapp-gcc/build/lib
cp: target /home/mhall/src/sdn_sensor/external/pktgen-dpdk/lib/common/lib/common/x86_64-native-linuxapp-gcc/build/lib is not a directory
/home/mhall/src/sdn_sensor/external/dpdk/mk/rte.lib.mk:146: recipe for target 'libcommon.a' failed
make[3]: *** [libcommon.a] Error 1
/home/mhall/src/sdn_sensor/external/dpdk/mk/rte.extlib.mk:42: recipe for target 'all' failed
make[2]: *** [all] Error 2
/home/mhall/src/sdn_sensor/external/dpdk/mk/rte.extsubdir.mk:46: recipe for target 'common' failed
make[1]: *** [common] Error 2
/home/mhall/src/sdn_sensor/external/dpdk/mk/rte.extsubdir.mk:46: recipe for target 'lib' failed
make: *** [lib] Error 2