From: Waldemar Brodkorb <wbx@openadk.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] jimtcl: fix sparc64 compile
Date: Mon, 23 Nov 2015 17:48:53 +0100 [thread overview]
Message-ID: <20151123164853.GA29207@waldemar-brodkorb.de> (raw)
It is general safe to use -fPIC for all architectures.
-fpic breaks sparc64 compile.
Generally gcc just optimize position independent code
for m68k, powerpc and sparc with -fpic.
The size differences are minimal, f.e. for powerpc:
text data bss dec hex filename
235983 5336 684 242003 3b153 output/target/usr/lib/libjim.0.75
236255 8456 684 245395 3be93 output/target/usr/lib/libjim.so.0.75
So instead of keeping special settings for sparc64 it would be better
to always use -fPIC in general.
Runtime tested on Qemu ARM, MIPS, PPC and SPARC64.
Fixes:
http://autobuild.buildroot.net/results/98f391ad13f22828c022f185c0166daabdb4c1ad/
Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
package/jimtcl/jimtcl.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
index 4afb217..50078e7 100644
--- a/package/jimtcl/jimtcl.mk
+++ b/package/jimtcl/jimtcl.mk
@@ -46,7 +46,10 @@ define JIMTCL_CONFIGURE_CMDS
)
endef
+# -fPIC works for any architecture
define JIMTCL_BUILD_CMDS
+ SH_CFLAGS="-fPIC" \
+ SHOBJ_CFLAGS="-fPIC" \
$(MAKE) -C $(@D)
endef
--
1.7.10.4
next reply other threads:[~2015-11-23 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 16:48 Waldemar Brodkorb [this message]
2015-11-23 17:29 ` [Buildroot] [PATCH] jimtcl: fix sparc64 compile Thomas Petazzoni
2015-11-23 17:40 ` Waldemar Brodkorb
2015-11-26 21:34 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123164853.GA29207@waldemar-brodkorb.de \
--to=wbx@openadk.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.