All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] jimtcl: fix sparc64 compile
Date: Thu, 26 Nov 2015 22:34:06 +0100	[thread overview]
Message-ID: <87vb8otpgx.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20151123164853.GA29207@waldemar-brodkorb.de> (Waldemar Brodkorb's message of "Mon, 23 Nov 2015 17:48:53 +0100")

>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > It is general safe to use -fPIC for all architectures.
 > -fpic breaks sparc64 compile.

 > Generally gcc just optimize position independent code
 > for m68k, powerpc and sparc with -fpic.
 > The size differences are minimal, f.e. for powerpc:
 >    text    data     bss     dec     hex filename
 >  235983    5336     684  242003   3b153 output/target/usr/lib/libjim.0.75
 >  236255    8456     684  245395   3be93 output/target/usr/lib/libjim.so.0.75

 > So instead of keeping special settings for sparc64 it would be better
 > to always use -fPIC in general.

 > Runtime tested on Qemu ARM, MIPS, PPC and SPARC64.
 > Fixes:
 > http://autobuild.buildroot.net/results/98f391ad13f22828c022f185c0166daabdb4c1ad/

 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Committed after changing the comment as suggested by Thomas, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2015-11-26 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 16:48 [Buildroot] [PATCH] jimtcl: fix sparc64 compile Waldemar Brodkorb
2015-11-23 17:29 ` Thomas Petazzoni
2015-11-23 17:40   ` Waldemar Brodkorb
2015-11-26 21:34 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb8otpgx.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.