* [patch] nfsd: fix a warning message
@ 2015-11-21 10:28 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-11-21 10:28 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: Jeff Layton, linux-nfs, kernel-janitors
The WARN() macro takes a condition and a format string. The condition
was accidentally left out here so it just prints the function name
instead of the message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 6b800b5..7af023f 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
base = resp->cstate.data_offset;
slot->sl_datalen = buf->len - base;
if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
- WARN("%s: sessions DRC could not cache compound\n", __func__);
+ WARN(1, "%s: sessions DRC could not cache compound\n",
+ __func__);
return;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] nfsd: fix a warning message
@ 2015-11-21 10:28 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-11-21 10:28 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: Jeff Layton, linux-nfs, kernel-janitors
The WARN() macro takes a condition and a format string. The condition
was accidentally left out here so it just prints the function name
instead of the message.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 6b800b5..7af023f 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
base = resp->cstate.data_offset;
slot->sl_datalen = buf->len - base;
if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
- WARN("%s: sessions DRC could not cache compound\n", __func__);
+ WARN(1, "%s: sessions DRC could not cache compound\n",
+ __func__);
return;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] nfsd: fix a warning message
2015-11-21 10:28 ` Dan Carpenter
@ 2015-11-22 13:04 ` Jeff Layton
-1 siblings, 0 replies; 6+ messages in thread
From: Jeff Layton @ 2015-11-22 13:04 UTC (permalink / raw)
To: Dan Carpenter; +Cc: J. Bruce Fields, linux-nfs, kernel-janitors
On Sat, 21 Nov 2015 13:28:50 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The WARN() macro takes a condition and a format string. The condition
> was accidentally left out here so it just prints the function name
> instead of the message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 6b800b5..7af023f 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
> base = resp->cstate.data_offset;
> slot->sl_datalen = buf->len - base;
> if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
> - WARN("%s: sessions DRC could not cache compound\n", __func__);
> + WARN(1, "%s: sessions DRC could not cache compound\n",
> + __func__);
> return;
> }
>
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] nfsd: fix a warning message
@ 2015-11-22 13:04 ` Jeff Layton
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Layton @ 2015-11-22 13:04 UTC (permalink / raw)
To: Dan Carpenter; +Cc: J. Bruce Fields, linux-nfs, kernel-janitors
On Sat, 21 Nov 2015 13:28:50 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The WARN() macro takes a condition and a format string. The condition
> was accidentally left out here so it just prints the function name
> instead of the message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 6b800b5..7af023f 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
> base = resp->cstate.data_offset;
> slot->sl_datalen = buf->len - base;
> if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
> - WARN("%s: sessions DRC could not cache compound\n", __func__);
> + WARN(1, "%s: sessions DRC could not cache compound\n",
> + __func__);
> return;
> }
>
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] nfsd: fix a warning message
2015-11-22 13:04 ` Jeff Layton
@ 2015-11-23 19:05 ` J. Bruce Fields
-1 siblings, 0 replies; 6+ messages in thread
From: J. Bruce Fields @ 2015-11-23 19:05 UTC (permalink / raw)
To: Jeff Layton; +Cc: Dan Carpenter, linux-nfs, kernel-janitors
On Sun, Nov 22, 2015 at 08:04:18AM -0500, Jeff Layton wrote:
> On Sat, 21 Nov 2015 13:28:50 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
Thanks, applying for 4.5.--b.
>
> > The WARN() macro takes a condition and a format string. The condition
> > was accidentally left out here so it just prints the function name
> > instead of the message.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> > index 6b800b5..7af023f 100644
> > --- a/fs/nfsd/nfs4state.c
> > +++ b/fs/nfsd/nfs4state.c
> > @@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
> > base = resp->cstate.data_offset;
> > slot->sl_datalen = buf->len - base;
> > if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
> > - WARN("%s: sessions DRC could not cache compound\n", __func__);
> > + WARN(1, "%s: sessions DRC could not cache compound\n",
> > + __func__);
> > return;
> > }
> >
>
> Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] nfsd: fix a warning message
@ 2015-11-23 19:05 ` J. Bruce Fields
0 siblings, 0 replies; 6+ messages in thread
From: J. Bruce Fields @ 2015-11-23 19:05 UTC (permalink / raw)
To: Jeff Layton; +Cc: Dan Carpenter, linux-nfs, kernel-janitors
On Sun, Nov 22, 2015 at 08:04:18AM -0500, Jeff Layton wrote:
> On Sat, 21 Nov 2015 13:28:50 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
Thanks, applying for 4.5.--b.
>
> > The WARN() macro takes a condition and a format string. The condition
> > was accidentally left out here so it just prints the function name
> > instead of the message.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> > index 6b800b5..7af023f 100644
> > --- a/fs/nfsd/nfs4state.c
> > +++ b/fs/nfsd/nfs4state.c
> > @@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
> > base = resp->cstate.data_offset;
> > slot->sl_datalen = buf->len - base;
> > if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
> > - WARN("%s: sessions DRC could not cache compound\n", __func__);
> > + WARN(1, "%s: sessions DRC could not cache compound\n",
> > + __func__);
> > return;
> > }
> >
>
> Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-23 19:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-21 10:28 [patch] nfsd: fix a warning message Dan Carpenter
2015-11-21 10:28 ` Dan Carpenter
2015-11-22 13:04 ` Jeff Layton
2015-11-22 13:04 ` Jeff Layton
2015-11-23 19:05 ` J. Bruce Fields
2015-11-23 19:05 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.