All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH -mm v2] mm: add page_check_address_transhuge helper
Date: Tue, 24 Nov 2015 13:29:41 +0900	[thread overview]
Message-ID: <20151124042941.GE705@swordfish> (raw)
In-Reply-To: <1448011913-12121-1-git-send-email-vdavydov@virtuozzo.com>

Hello,

On (11/20/15 12:31), Vladimir Davydov wrote:
[..]
> -	if (ptep_clear_flush_young_notify(vma, address, pte)) {
> -		/*
> -		 * Don't treat a reference through a sequentially read
> -		 * mapping as such.  If the page has been used in
> -		 * another mapping, we will catch it; if this other
> -		 * mapping is already gone, the unmap path will have
> -		 * set PG_referenced or activated the page.
> -		 */
> -		if (likely(!(vma->vm_flags & VM_SEQ_READ)))
> +	if (pte) {
> +		if (ptep_clear_flush_young_notify(vma, address, pte)) {
> +			/*
> +			 * Don't treat a reference through a sequentially read
> +			 * mapping as such.  If the page has been used in
> +			 * another mapping, we will catch it; if this other
> +			 * mapping is already gone, the unmap path will have
> +			 * set PG_referenced or activated the page.
> +			 */
> +			if (likely(!(vma->vm_flags & VM_SEQ_READ)))
> +				referenced++;
> +		}
> +		pte_unmap(pte);
> +	} else {
> +		if (pmdp_clear_flush_young_notify(vma, address, pmd))
>  			referenced++;
>  	}

# CONFIG_TRANSPARENT_HUGEPAGE is not set

x86_64, 4.4.0-rc2-mm1


mm/built-in.o: In function `page_referenced_one':
rmap.c:(.text+0x32070): undefined reference to `pmdp_clear_flush_young'


	-ss

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH -mm v2] mm: add page_check_address_transhuge helper
Date: Tue, 24 Nov 2015 13:29:41 +0900	[thread overview]
Message-ID: <20151124042941.GE705@swordfish> (raw)
In-Reply-To: <1448011913-12121-1-git-send-email-vdavydov@virtuozzo.com>

Hello,

On (11/20/15 12:31), Vladimir Davydov wrote:
[..]
> -	if (ptep_clear_flush_young_notify(vma, address, pte)) {
> -		/*
> -		 * Don't treat a reference through a sequentially read
> -		 * mapping as such.  If the page has been used in
> -		 * another mapping, we will catch it; if this other
> -		 * mapping is already gone, the unmap path will have
> -		 * set PG_referenced or activated the page.
> -		 */
> -		if (likely(!(vma->vm_flags & VM_SEQ_READ)))
> +	if (pte) {
> +		if (ptep_clear_flush_young_notify(vma, address, pte)) {
> +			/*
> +			 * Don't treat a reference through a sequentially read
> +			 * mapping as such.  If the page has been used in
> +			 * another mapping, we will catch it; if this other
> +			 * mapping is already gone, the unmap path will have
> +			 * set PG_referenced or activated the page.
> +			 */
> +			if (likely(!(vma->vm_flags & VM_SEQ_READ)))
> +				referenced++;
> +		}
> +		pte_unmap(pte);
> +	} else {
> +		if (pmdp_clear_flush_young_notify(vma, address, pmd))
>  			referenced++;
>  	}

# CONFIG_TRANSPARENT_HUGEPAGE is not set

x86_64, 4.4.0-rc2-mm1


mm/built-in.o: In function `page_referenced_one':
rmap.c:(.text+0x32070): undefined reference to `pmdp_clear_flush_young'


	-ss

  reply	other threads:[~2015-11-24  4:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  9:31 [PATCH -mm v2] mm: add page_check_address_transhuge helper Vladimir Davydov
2015-11-20  9:31 ` Vladimir Davydov
2015-11-24  4:29 ` Sergey Senozhatsky [this message]
2015-11-24  4:29   ` Sergey Senozhatsky
2015-11-24  9:09   ` Kirill A. Shutemov
2015-11-24  9:09     ` Kirill A. Shutemov
2015-11-24  9:23     ` Sergey Senozhatsky
2015-11-24  9:23       ` Sergey Senozhatsky
2015-11-24  9:36     ` Vladimir Davydov
2015-11-24  9:36       ` Vladimir Davydov
2015-11-24  9:46       ` Vladimir Davydov
2015-11-24  9:46         ` Vladimir Davydov
2015-11-24 10:09         ` Sergey Senozhatsky
2015-11-24 10:09           ` Sergey Senozhatsky
2015-11-24  9:57       ` Kirill A. Shutemov
2015-11-24  9:57         ` Kirill A. Shutemov
2015-11-24 18:15       ` Johannes Weiner
2015-11-24 18:15         ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124042941.GE705@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vdavydov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.