All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6q-icore-rqs: Add Engicam IMX6 Q7 initial support
Date: Tue, 24 Nov 2015 17:19:55 +0800	[thread overview]
Message-ID: <20151124091955.GU11999@tiger> (raw)
In-Reply-To: <1447673895.3144.16.camel@pengutronix.de>

On Mon, Nov 16, 2015 at 12:38:15PM +0100, Lucas Stach wrote:
<snip>
> > > > +		reg_sd3_vmmc: sd3_vmmc {
> > > > +			compatible = "regulator-fixed";
> > > > +			regulator-name = "P3V3_SD3_SWITCHED";
> > > > +			regulator-min-microvolt = <3300000>;
> > > > +			regulator-max-microvolt = <3300000>;
> > > > +			gpio = <&gpio1 4 GPIO_ACTIVE_LOW>;
> > > > +			regulator-boot-on;
> > > > +			regulator-always-on;
> > > > +		};
> > > 
> > > A lot of those regulators look like they don't need to be always-on.
> > > 
> > > Also the use of a simple-bus, while giving some structure to the DT is
> > > considered bad style as it doesn't reflect any real hardware.
> > > 
> > 
> > I will check how other boards do it
> > 
> Note that there are a lot of bad examples still around. What you need to
> do is essentially just remove the additional DT level of the regulator
> bus. The regulators are board components that belong to the same level
> as the usb hub below, or the memory node above.

Will kernel populate platform_device for these fixed regulators if they
are being put directly under root node?  Kernel used to only do that for
devices under simple-bus.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Michael Trimarchi
	<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: imx6q-icore-rqs: Add Engicam IMX6 Q7 initial support
Date: Tue, 24 Nov 2015 17:19:55 +0800	[thread overview]
Message-ID: <20151124091955.GU11999@tiger> (raw)
In-Reply-To: <1447673895.3144.16.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

On Mon, Nov 16, 2015 at 12:38:15PM +0100, Lucas Stach wrote:
<snip>
> > > > +		reg_sd3_vmmc: sd3_vmmc {
> > > > +			compatible = "regulator-fixed";
> > > > +			regulator-name = "P3V3_SD3_SWITCHED";
> > > > +			regulator-min-microvolt = <3300000>;
> > > > +			regulator-max-microvolt = <3300000>;
> > > > +			gpio = <&gpio1 4 GPIO_ACTIVE_LOW>;
> > > > +			regulator-boot-on;
> > > > +			regulator-always-on;
> > > > +		};
> > > 
> > > A lot of those regulators look like they don't need to be always-on.
> > > 
> > > Also the use of a simple-bus, while giving some structure to the DT is
> > > considered bad style as it doesn't reflect any real hardware.
> > > 
> > 
> > I will check how other boards do it
> > 
> Note that there are a lot of bad examples still around. What you need to
> do is essentially just remove the additional DT level of the regulator
> bus. The regulators are board components that belong to the same level
> as the usb hub below, or the memory node above.

Will kernel populate platform_device for these fixed regulators if they
are being put directly under root node?  Kernel used to only do that for
devices under simple-bus.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-24  9:19 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15 10:54 [PATCH] ARM: dts: imx6q-icore-rqs: Add Engicam IMX6 Q7 initial support Michael Trimarchi
2015-11-15 10:54 ` Michael Trimarchi
2015-11-16  9:19 ` Lucas Stach
2015-11-16  9:19   ` Lucas Stach
2015-11-16 11:29   ` Michael Trimarchi
2015-11-16 11:29     ` Michael Trimarchi
2015-11-16 11:38     ` Lucas Stach
2015-11-16 11:38       ` Lucas Stach
2015-11-16 11:41       ` Michael Trimarchi
2015-11-16 11:41         ` Michael Trimarchi
2015-11-16 11:51         ` Lucas Stach
2015-11-16 11:51           ` Lucas Stach
2015-11-16 11:54           ` Michael Trimarchi
2015-11-16 11:54             ` Michael Trimarchi
2015-11-16 17:23             ` [PATCH V2] " Michael Trimarchi
2015-11-16 17:23               ` Michael Trimarchi
2015-11-16 22:02               ` Michael Trimarchi
2015-11-16 22:02                 ` Michael Trimarchi
2015-11-17  9:31               ` Lucas Stach
2015-11-17  9:31                 ` Lucas Stach
2015-11-18 15:10                 ` [PATCH V3] " Michael Trimarchi
2015-11-18 15:10                   ` Michael Trimarchi
2015-11-25 18:14                   ` Michael Trimarchi
2015-11-25 18:14                     ` Michael Trimarchi
2015-12-02  2:09                     ` Shawn Guo
2015-12-02  2:09                       ` Shawn Guo
2015-12-02  9:15                       ` Michael Trimarchi
2015-12-02  9:15                         ` Michael Trimarchi
2015-12-11  8:36                   ` Shawn Guo
2015-12-11  8:36                     ` Shawn Guo
2015-12-14  8:45                     ` Michael Trimarchi
2015-12-14  8:45                       ` Michael Trimarchi
2015-12-16 18:12                       ` Michael Trimarchi
2015-12-16 18:12                         ` Michael Trimarchi
2015-12-21  6:12                         ` Shawn Guo
2015-12-21  6:12                           ` Shawn Guo
2015-12-23  2:27                         ` Shawn Guo
2015-12-23  2:27                           ` Shawn Guo
2015-12-23  9:18                           ` Michael Trimarchi
2015-12-23  9:18                             ` Michael Trimarchi
2015-12-24  9:06                           ` [PATCH V4] " Michael Trimarchi
2015-12-24  9:06                             ` Michael Trimarchi
2015-12-24  9:13                             ` Michael Trimarchi
2015-12-24  9:13                               ` Michael Trimarchi
2015-12-24  9:24                           ` [PATCH V5] " Michael Trimarchi
2015-12-24  9:24                             ` Michael Trimarchi
2016-01-12 17:37                             ` Michael Trimarchi
2016-01-12 17:37                               ` Michael Trimarchi
2016-01-28  2:04                             ` Shawn Guo
2016-01-28  2:04                               ` Shawn Guo
2016-01-28  2:12                               ` Michael Trimarchi
2016-01-28  2:12                                 ` Michael Trimarchi
2016-01-29  8:01                               ` [PATCH V6] " Michael Trimarchi
2016-01-29  8:01                                 ` Michael Trimarchi
2016-02-01 11:07                                 ` Shawn Guo
2016-02-01 11:07                                   ` Shawn Guo
2015-11-24  9:19       ` Shawn Guo [this message]
2015-11-24  9:19         ` [PATCH] " Shawn Guo
2015-11-24  9:31         ` Lucas Stach
2015-11-24  9:31           ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124091955.GU11999@tiger \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.