From: Lee Jones <lee.jones@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Support Opensource <support.opensource@diasemi.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: constify da903x_chip_ops structure
Date: Tue, 24 Nov 2015 16:30:11 +0000 [thread overview]
Message-ID: <20151124163011.GA12874@x1> (raw)
In-Reply-To: <1447430631-10455-1-git-send-email-Julia.Lawall@lip6.fr>
On Fri, 13 Nov 2015, Julia Lawall wrote:
> The da903x_chip_ops structure is never modified, so declare it
> as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mfd/da903x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index 37e4426..f6a0459 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -60,7 +60,7 @@ struct da903x_chip_ops {
> struct da903x_chip {
> struct i2c_client *client;
> struct device *dev;
> - struct da903x_chip_ops *ops;
> + const struct da903x_chip_ops *ops;
>
> int type;
> uint32_t events_mask;
> @@ -424,7 +424,7 @@ static irqreturn_t da903x_irq_handler(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static struct da903x_chip_ops da903x_ops[] = {
> +static const struct da903x_chip_ops da903x_ops[] = {
> [0] = {
> .init_chip = da9030_init_chip,
> .unmask_events = da9030_unmask_events,
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Support Opensource <support.opensource@diasemi.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: constify da903x_chip_ops structure
Date: Tue, 24 Nov 2015 16:30:11 +0000 [thread overview]
Message-ID: <20151124163011.GA12874@x1> (raw)
In-Reply-To: <1447430631-10455-1-git-send-email-Julia.Lawall@lip6.fr>
On Fri, 13 Nov 2015, Julia Lawall wrote:
> The da903x_chip_ops structure is never modified, so declare it
> as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mfd/da903x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index 37e4426..f6a0459 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -60,7 +60,7 @@ struct da903x_chip_ops {
> struct da903x_chip {
> struct i2c_client *client;
> struct device *dev;
> - struct da903x_chip_ops *ops;
> + const struct da903x_chip_ops *ops;
>
> int type;
> uint32_t events_mask;
> @@ -424,7 +424,7 @@ static irqreturn_t da903x_irq_handler(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static struct da903x_chip_ops da903x_ops[] = {
> +static const struct da903x_chip_ops da903x_ops[] = {
> [0] = {
> .init_chip = da9030_init_chip,
> .unmask_events = da9030_unmask_events,
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-11-24 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 16:03 [PATCH] mfd: constify da903x_chip_ops structure Julia Lawall
2015-11-13 16:03 ` Julia Lawall
2015-11-24 16:30 ` Lee Jones [this message]
2015-11-24 16:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124163011.GA12874@x1 \
--to=lee.jones@linaro.org \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.