From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-rdma@vger.kernel.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 3/8] svcrdma: Add svc_rdma_get_context() API that is allowed to fail
Date: Tue, 24 Nov 2015 12:02:12 -0800 [thread overview]
Message-ID: <20151124200212.GA10208@infradead.org> (raw)
In-Reply-To: <7717B6B1-4A27-4D8A-8BCC-528CEC6DB54D@oracle.com>
On Tue, Nov 24, 2015 at 09:24:51AM -0500, Chuck Lever wrote:
> There is only one (new) call site that needs it. I can simplify
> this patch as Sagi suggested before, but it seems silly to
> introduce the extra clutter of adding a gfp_t argument
> everywhere.
We a) generally try to pass the gfp_t around if we expect calling
contexts to change, and b the changes to the 6 callers are probably
still smaller than this patch :)
> > And if we have any way to avoid the __GFP_NOFAIL
> > I'd really appreciate if we could give that a try.
>
> I???m not introducing the flag here.
>
> Changing all the svc_rdma_get_context() call sites to handle
> allocation failure (when it is already highly unlikely) is
> a lot of needless work, IMO, and not related to supporting
> bi-directional RPC.
Ok.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux NFS Mailing List
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v1 3/8] svcrdma: Add svc_rdma_get_context() API that is allowed to fail
Date: Tue, 24 Nov 2015 12:02:12 -0800 [thread overview]
Message-ID: <20151124200212.GA10208@infradead.org> (raw)
In-Reply-To: <7717B6B1-4A27-4D8A-8BCC-528CEC6DB54D-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Tue, Nov 24, 2015 at 09:24:51AM -0500, Chuck Lever wrote:
> There is only one (new) call site that needs it. I can simplify
> this patch as Sagi suggested before, but it seems silly to
> introduce the extra clutter of adding a gfp_t argument
> everywhere.
We a) generally try to pass the gfp_t around if we expect calling
contexts to change, and b the changes to the 6 callers are probably
still smaller than this patch :)
> > And if we have any way to avoid the __GFP_NOFAIL
> > I'd really appreciate if we could give that a try.
>
> I???m not introducing the flag here.
>
> Changing all the svc_rdma_get_context() call sites to handle
> allocation failure (when it is already highly unlikely) is
> a lot of needless work, IMO, and not related to supporting
> bi-directional RPC.
Ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-24 20:02 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 22:20 [PATCH v1 0/8] NFS/RDMA server patches for 4.5 Chuck Lever
2015-11-23 22:20 ` Chuck Lever
2015-11-23 22:20 ` [PATCH v1 1/8] svcrdma: Do not send XDR roundup bytes for a write chunk Chuck Lever
2015-11-23 22:20 ` Chuck Lever
2015-11-23 22:20 ` [PATCH v1 2/8] svcrdma: Define maximum number of backchannel requests Chuck Lever
2015-11-23 22:20 ` Chuck Lever
2015-11-24 0:39 ` Tom Talpey
2015-11-24 0:39 ` Tom Talpey
2015-11-24 1:09 ` Chuck Lever
2015-11-24 1:09 ` Chuck Lever
2015-11-24 1:19 ` Tom Talpey
2015-11-24 1:19 ` Tom Talpey
2015-11-24 1:36 ` Trond Myklebust
2015-11-24 1:36 ` Trond Myklebust
2015-11-24 1:36 ` Chuck Lever
2015-11-24 1:36 ` Chuck Lever
2015-11-24 1:47 ` Tom Talpey
2015-11-24 1:47 ` Tom Talpey
2015-11-23 22:20 ` [PATCH v1 3/8] svcrdma: Add svc_rdma_get_context() API that is allowed to fail Chuck Lever
2015-11-23 22:20 ` Chuck Lever
2015-11-24 6:55 ` Christoph Hellwig
2015-11-24 6:55 ` Christoph Hellwig
2015-11-24 14:24 ` Chuck Lever
2015-11-24 14:24 ` Chuck Lever
2015-11-24 20:02 ` Christoph Hellwig [this message]
2015-11-24 20:02 ` Christoph Hellwig
2015-11-24 20:06 ` Chuck Lever
2015-11-24 20:06 ` Chuck Lever
2015-12-04 15:29 ` Chuck Lever
2015-12-04 15:29 ` Chuck Lever
2015-11-23 22:20 ` [PATCH v1 4/8] svcrdma: Add infrastructure to send backwards direction RPC/RDMA calls Chuck Lever
2015-11-23 22:20 ` Chuck Lever
2015-11-23 22:20 ` [PATCH v1 5/8] svcrdma: Add infrastructure to receive backwards direction RPC/RDMA replies Chuck Lever
2015-11-23 22:20 ` Chuck Lever
2015-11-24 0:44 ` Tom Talpey
2015-11-24 0:44 ` Tom Talpey
2015-11-24 1:47 ` Chuck Lever
2015-11-24 1:47 ` Chuck Lever
2015-11-24 2:02 ` Tom Talpey
2015-11-24 2:02 ` Tom Talpey
2015-11-23 22:21 ` [PATCH v1 6/8] xprtrdma: Add class for RDMA backwards direction transport Chuck Lever
2015-11-23 22:21 ` Chuck Lever
2015-11-24 0:49 ` Tom Talpey
2015-11-24 0:49 ` Tom Talpey
2015-11-23 22:21 ` [PATCH v1 7/8] svcrdma: No need to count WRs in svc_rdma_send() Chuck Lever
2015-11-23 22:21 ` Chuck Lever
2015-11-23 22:21 ` [PATCH v1 8/8] svcrdma: Remove svc_rdma_fastreg_mr::access_flags field Chuck Lever
2015-11-23 22:21 ` Chuck Lever
2015-11-24 0:52 ` Tom Talpey
2015-11-24 0:52 ` Tom Talpey
2015-11-24 0:53 ` Chuck Lever
2015-11-24 0:53 ` Chuck Lever
2015-11-24 6:39 ` Christoph Hellwig
2015-11-24 6:39 ` Christoph Hellwig
2015-11-24 14:08 ` Chuck Lever
2015-11-24 14:08 ` Chuck Lever
2015-11-24 16:03 ` Christoph Hellwig
2015-11-24 16:03 ` Christoph Hellwig
2015-11-24 16:04 ` Chuck Lever
2015-11-24 16:04 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124200212.GA10208@infradead.org \
--to=hch@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.