From: Jisheng Zhang <jszhang@marvell.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Linus Walleij <linus.walleij@linaro.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] pinctrl: berlin: guard sub-directory with CONFIG_PINCTRL_BERLIN
Date: Tue, 24 Nov 2015 20:02:59 +0800 [thread overview]
Message-ID: <20151124200259.6c002d1f@xhacker> (raw)
In-Reply-To: <1448365524-12605-2-git-send-email-yamada.masahiro@socionext.com>
On Tue, 24 Nov 2015 20:45:22 +0900
Masahiro Yamada wrote:
> CONFIG_PINCTRL_BERLIN is more suitable than CONFIG_ARCH_BERLIN
> to guard the drivers/pinctrl/berlin/ directory.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
I'm not maintainers, but this patch looks good to me. So if you need,
Acked-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>
> drivers/pinctrl/Makefile | 2 +-
> drivers/pinctrl/berlin/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 738cb49..17c0206 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -41,7 +41,7 @@ obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o
> obj-$(CONFIG_PINCTRL_ZYNQ) += pinctrl-zynq.o
>
> obj-$(CONFIG_ARCH_BCM) += bcm/
> -obj-$(CONFIG_ARCH_BERLIN) += berlin/
> +obj-$(CONFIG_PINCTRL_BERLIN) += berlin/
> obj-y += freescale/
> obj-$(CONFIG_X86) += intel/
> obj-$(CONFIG_PLAT_ORION) += mvebu/
> diff --git a/drivers/pinctrl/berlin/Makefile b/drivers/pinctrl/berlin/Makefile
> index 06f9402..6f641ce 100644
> --- a/drivers/pinctrl/berlin/Makefile
> +++ b/drivers/pinctrl/berlin/Makefile
> @@ -1,4 +1,4 @@
> -obj-$(CONFIG_PINCTRL_BERLIN) += berlin.o
> +obj-y += berlin.o
> obj-$(CONFIG_PINCTRL_BERLIN_BG2) += berlin-bg2.o
> obj-$(CONFIG_PINCTRL_BERLIN_BG2CD) += berlin-bg2cd.o
> obj-$(CONFIG_PINCTRL_BERLIN_BG2Q) += berlin-bg2q.o
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: <linux-gpio@vger.kernel.org>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Linus Walleij <linus.walleij@linaro.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] pinctrl: berlin: guard sub-directory with CONFIG_PINCTRL_BERLIN
Date: Tue, 24 Nov 2015 20:02:59 +0800 [thread overview]
Message-ID: <20151124200259.6c002d1f@xhacker> (raw)
In-Reply-To: <1448365524-12605-2-git-send-email-yamada.masahiro@socionext.com>
On Tue, 24 Nov 2015 20:45:22 +0900
Masahiro Yamada wrote:
> CONFIG_PINCTRL_BERLIN is more suitable than CONFIG_ARCH_BERLIN
> to guard the drivers/pinctrl/berlin/ directory.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
I'm not maintainers, but this patch looks good to me. So if you need,
Acked-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>
> drivers/pinctrl/Makefile | 2 +-
> drivers/pinctrl/berlin/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 738cb49..17c0206 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -41,7 +41,7 @@ obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o
> obj-$(CONFIG_PINCTRL_ZYNQ) += pinctrl-zynq.o
>
> obj-$(CONFIG_ARCH_BCM) += bcm/
> -obj-$(CONFIG_ARCH_BERLIN) += berlin/
> +obj-$(CONFIG_PINCTRL_BERLIN) += berlin/
> obj-y += freescale/
> obj-$(CONFIG_X86) += intel/
> obj-$(CONFIG_PLAT_ORION) += mvebu/
> diff --git a/drivers/pinctrl/berlin/Makefile b/drivers/pinctrl/berlin/Makefile
> index 06f9402..6f641ce 100644
> --- a/drivers/pinctrl/berlin/Makefile
> +++ b/drivers/pinctrl/berlin/Makefile
> @@ -1,4 +1,4 @@
> -obj-$(CONFIG_PINCTRL_BERLIN) += berlin.o
> +obj-y += berlin.o
> obj-$(CONFIG_PINCTRL_BERLIN_BG2) += berlin-bg2.o
> obj-$(CONFIG_PINCTRL_BERLIN_BG2CD) += berlin-bg2cd.o
> obj-$(CONFIG_PINCTRL_BERLIN_BG2Q) += berlin-bg2q.o
next prev parent reply other threads:[~2015-11-24 12:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 11:45 [PATCH 0/3] pinctrl: use CONFIG_PINCTRL_* to gurad subdirectories Masahiro Yamada
2015-11-24 11:45 ` Masahiro Yamada
2015-11-24 11:45 ` [PATCH 1/3] pinctrl: berlin: guard sub-directory with CONFIG_PINCTRL_BERLIN Masahiro Yamada
2015-11-24 12:02 ` Jisheng Zhang [this message]
2015-11-24 12:02 ` Jisheng Zhang
2015-11-28 11:22 ` Sebastian Hesselbarth
2015-12-01 9:40 ` Linus Walleij
2015-11-24 11:45 ` [PATCH 2/3] pinctrl: mvebu: guard sub-directory with CONFIG_PINCTRL_MVEBU Masahiro Yamada
2015-12-01 9:41 ` Linus Walleij
2015-11-24 11:45 ` [PATCH 3/3] pinctrl: spear: guard sub-directory with CONFIG_PINCTRL_SPEAR Masahiro Yamada
2015-11-24 11:45 ` Masahiro Yamada
2015-12-01 9:42 ` Linus Walleij
2015-12-01 9:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124200259.6c002d1f@xhacker \
--to=jszhang@marvell.com \
--cc=antoine.tenart@free-electrons.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.