All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Michael Wang <yun.wang@profitbricks.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date: Wed, 25 Nov 2015 16:08:06 +0100	[thread overview]
Message-ID: <20151125150806.GG2064@8bytes.org> (raw)
In-Reply-To: <564F051E.9010703@profitbricks.com>

On Fri, Nov 20, 2015 at 12:33:50PM +0100, Michael Wang wrote:
> The kmemleak testing on 3.18.24 show:
> 
> unreferenced object 0xffff880233ff9010 (size 16):
>   comm "swapper/0", pid 1, jiffies 4294937440 (age 2010.490s)
>   hex dump (first 16 bytes):
>     0a 0a 00 00 20 00 00 00 00 44 fb 33 02 88 ff ff  .... ....D.3....
>   backtrace:
>     [<ffffffff8118192d>] create_object+0x10d/0x2d0
>     [<ffffffff815c2d4b>] kmemleak_alloc+0x5b/0xc0
>     [<ffffffff8116dd19>] kmem_cache_alloc_trace+0xb9/0x160
>     [<ffffffff814ffe51>] get_irq_table+0x151/0x380
> 
> This is caused by the 'irq_lookup_table' was allocated with
> __get_free_pages() which won't create kmemleak object, thus it's
> pointers won't be count as referencing 'irq_remap_table' in
> kmemleak scan.

Isn't it better to allocate the kmemleak object manually instead of
ignoring all irq-table pointers? With this patch we might not notice any
real leak of irq-tables.



	Joerg

  parent reply	other threads:[~2015-11-25 15:08 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 11:09 [RFC PATCH] iommu/amd: make kmemleak ignore the 'irq_remap_table' object Michael Wang
2015-11-20 11:33 ` [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang
2015-11-20 12:31   ` Michael Wang
     [not found]   ` <564F051E.9010703-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-11-25 11:14     ` Michael Wang
2015-11-25 11:14       ` Michael Wang
2015-11-25 15:08   ` Joerg Roedel [this message]
     [not found]     ` <20151125150806.GG2064-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-11-25 15:14       ` Michael Wang
2015-11-25 15:14         ` Michael Wang
2015-12-02 10:37         ` Michael Wang
2015-12-02 10:52           ` Catalin Marinas
     [not found]             ` <CAHkRjk5QNQiNeJTcjKFQzpac_4us_3Ts1w4+uRw6TY16LbgsJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-02 10:56               ` Michael Wang
2015-12-02 10:56                 ` Michael Wang
2015-12-02 11:31                 ` Catalin Marinas
     [not found]                   ` <CAHkRjk5WzPT1gRaa=3qyrp1gcee9ZQKF_rU42FAu0C6ep8JPug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-02 11:38                     ` Michael Wang
2015-12-02 11:38                       ` Michael Wang
     [not found]                       ` <565ED81B.3020606-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 11:51                         ` Joerg Roedel
2015-12-02 11:51                           ` Joerg Roedel
     [not found]                           ` <20151202115142.GD18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-12-02 12:31                             ` Michael Wang
2015-12-02 12:31                               ` Michael Wang
2015-12-02 12:53                               ` Borislav Petkov
     [not found]                                 ` <20151202125315.GB3910-fF5Pk5pvG8Y@public.gmane.org>
2015-12-02 13:01                                   ` Michael Wang
2015-12-02 13:01                                     ` Michael Wang
     [not found]                                     ` <565EEBC3.5050807-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 13:13                                       ` Borislav Petkov
2015-12-02 13:13                                         ` Borislav Petkov
2015-12-02 13:18                                         ` Michael Wang
2015-12-02 13:40                                           ` Borislav Petkov
2015-12-02 13:48                                             ` Michael Wang
2015-12-02 13:59                                               ` Borislav Petkov
     [not found]                                                 ` <20151202135931.GF3783-fF5Pk5pvG8Y@public.gmane.org>
2015-12-02 14:09                                                   ` Michael Wang
2015-12-02 14:09                                                     ` Michael Wang
     [not found]                                                     ` <565EFB8E.4020600-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 14:13                                                       ` Borislav Petkov
2015-12-02 14:13                                                         ` Borislav Petkov
     [not found]                                                         ` <20151202141309.GG3783-fF5Pk5pvG8Y@public.gmane.org>
2015-12-02 14:21                                                           ` Michael Wang
2015-12-02 14:21                                                             ` Michael Wang
2015-12-02 17:36                                                   ` Catalin Marinas
2015-12-02 17:36                                                     ` Catalin Marinas
     [not found]                                                     ` <CAHkRjk4DdRE6=tN7VZu67Bsdty_4uT2GSbUff5MwP_nSJ+uj4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-02 18:40                                                       ` Borislav Petkov
2015-12-02 18:40                                                         ` Borislav Petkov
2015-12-03  8:47                                                     ` Michael Wang
     [not found]                               ` <565EE4AA.4070309-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 12:56                                 ` Joerg Roedel
2015-12-02 12:56                                   ` Joerg Roedel
     [not found]                                   ` <20151202125636.GE18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-12-02 13:07                                     ` Michael Wang
2015-12-02 13:07                                       ` Michael Wang
2015-12-02 11:17               ` Joerg Roedel
2015-12-02 11:17                 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125150806.GG2064@8bytes.org \
    --to=joro@8bytes.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yun.wang@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.