From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Catalin Marinas
<catalin.marinas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date: Wed, 2 Dec 2015 13:56:36 +0100 [thread overview]
Message-ID: <20151202125636.GE18805@8bytes.org> (raw)
In-Reply-To: <565EE4AA.4070309-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote:
> It's not my work or your work... it's a defect in the module and maintainer
> should take responsibility on fixing it, correct?
No, its a false positive from an in-kernel checking tool, the iommu
driver is correct. You just sent a patch to silence the false positive
report.
> We're very willing to help, but as I mentioned we are out of resource for
> testing at this moment, but we can send you a new patch without testing,
> will that works for you?
This should be testable on any AMD IOMMU system with working interrupt
remapping. I will probably have no time to test this, if you really
can't test yourself, try to get a Tested-by from someone else.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Michael Wang <yun.wang@profitbricks.com>
Cc: Catalin Marinas <catalin.marinas@gmail.com>,
iommu@lists.linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date: Wed, 2 Dec 2015 13:56:36 +0100 [thread overview]
Message-ID: <20151202125636.GE18805@8bytes.org> (raw)
In-Reply-To: <565EE4AA.4070309@profitbricks.com>
On Wed, Dec 02, 2015 at 01:31:38PM +0100, Michael Wang wrote:
> It's not my work or your work... it's a defect in the module and maintainer
> should take responsibility on fixing it, correct?
No, its a false positive from an in-kernel checking tool, the iommu
driver is correct. You just sent a patch to silence the false positive
report.
> We're very willing to help, but as I mentioned we are out of resource for
> testing at this moment, but we can send you a new patch without testing,
> will that works for you?
This should be testable on any AMD IOMMU system with working interrupt
remapping. I will probably have no time to test this, if you really
can't test yourself, try to get a Tested-by from someone else.
Joerg
next prev parent reply other threads:[~2015-12-02 12:56 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 11:09 [RFC PATCH] iommu/amd: make kmemleak ignore the 'irq_remap_table' object Michael Wang
2015-11-20 11:33 ` [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang
2015-11-20 12:31 ` Michael Wang
[not found] ` <564F051E.9010703-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-11-25 11:14 ` Michael Wang
2015-11-25 11:14 ` Michael Wang
2015-11-25 15:08 ` Joerg Roedel
[not found] ` <20151125150806.GG2064-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-11-25 15:14 ` Michael Wang
2015-11-25 15:14 ` Michael Wang
2015-12-02 10:37 ` Michael Wang
2015-12-02 10:52 ` Catalin Marinas
[not found] ` <CAHkRjk5QNQiNeJTcjKFQzpac_4us_3Ts1w4+uRw6TY16LbgsJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-02 10:56 ` Michael Wang
2015-12-02 10:56 ` Michael Wang
2015-12-02 11:31 ` Catalin Marinas
[not found] ` <CAHkRjk5WzPT1gRaa=3qyrp1gcee9ZQKF_rU42FAu0C6ep8JPug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-02 11:38 ` Michael Wang
2015-12-02 11:38 ` Michael Wang
[not found] ` <565ED81B.3020606-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 11:51 ` Joerg Roedel
2015-12-02 11:51 ` Joerg Roedel
[not found] ` <20151202115142.GD18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-12-02 12:31 ` Michael Wang
2015-12-02 12:31 ` Michael Wang
2015-12-02 12:53 ` Borislav Petkov
[not found] ` <20151202125315.GB3910-fF5Pk5pvG8Y@public.gmane.org>
2015-12-02 13:01 ` Michael Wang
2015-12-02 13:01 ` Michael Wang
[not found] ` <565EEBC3.5050807-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 13:13 ` Borislav Petkov
2015-12-02 13:13 ` Borislav Petkov
2015-12-02 13:18 ` Michael Wang
2015-12-02 13:40 ` Borislav Petkov
2015-12-02 13:48 ` Michael Wang
2015-12-02 13:59 ` Borislav Petkov
[not found] ` <20151202135931.GF3783-fF5Pk5pvG8Y@public.gmane.org>
2015-12-02 14:09 ` Michael Wang
2015-12-02 14:09 ` Michael Wang
[not found] ` <565EFB8E.4020600-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 14:13 ` Borislav Petkov
2015-12-02 14:13 ` Borislav Petkov
[not found] ` <20151202141309.GG3783-fF5Pk5pvG8Y@public.gmane.org>
2015-12-02 14:21 ` Michael Wang
2015-12-02 14:21 ` Michael Wang
2015-12-02 17:36 ` Catalin Marinas
2015-12-02 17:36 ` Catalin Marinas
[not found] ` <CAHkRjk4DdRE6=tN7VZu67Bsdty_4uT2GSbUff5MwP_nSJ+uj4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-02 18:40 ` Borislav Petkov
2015-12-02 18:40 ` Borislav Petkov
2015-12-03 8:47 ` Michael Wang
[not found] ` <565EE4AA.4070309-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-12-02 12:56 ` Joerg Roedel [this message]
2015-12-02 12:56 ` Joerg Roedel
[not found] ` <20151202125636.GE18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-12-02 13:07 ` Michael Wang
2015-12-02 13:07 ` Michael Wang
2015-12-02 11:17 ` Joerg Roedel
2015-12-02 11:17 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202125636.GE18805@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=catalin.marinas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.