All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: KASAN failures in X-Gene ethernet driver in v4.4-rc2
Date: Wed, 25 Nov 2015 16:34:02 +0000	[thread overview]
Message-ID: <20151125163402.GA29094@leverpostej> (raw)
In-Reply-To: <1448468256.24696.5.camel@edumazet-glaptop2.roam.corp.google.com>

On Wed, Nov 25, 2015 at 08:17:36AM -0800, Eric Dumazet wrote:
> On Wed, 2015-11-25 at 15:59 +0000, Mark Rutland wrote:
> > xgene_enet_start_xmit
> 
> Please try following trivial fix

With that applied KASAN is silent, despite my efforts to trigger the
issue, so it looks like that fixes it.

Thanks,
Mark.

> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 1adfe7036843..9147a0107c44 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -450,12 +450,12 @@ static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb,
>  		return NETDEV_TX_OK;
>  	}
>  
> -	pdata->ring_ops->wr_cmd(tx_ring, count);
>  	skb_tx_timestamp(skb);
>  
>  	pdata->stats.tx_packets++;
>  	pdata->stats.tx_bytes += skb->len;
>  
> +	pdata->ring_ops->wr_cmd(tx_ring, count);
>  	return NETDEV_TX_OK;
>  }
>  
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, isubramanian@apm.com, kchudgar@apm.com,
	linux-kernel@vger.kernel.org, ryabinin.a.a@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2
Date: Wed, 25 Nov 2015 16:34:02 +0000	[thread overview]
Message-ID: <20151125163402.GA29094@leverpostej> (raw)
In-Reply-To: <1448468256.24696.5.camel@edumazet-glaptop2.roam.corp.google.com>

On Wed, Nov 25, 2015 at 08:17:36AM -0800, Eric Dumazet wrote:
> On Wed, 2015-11-25 at 15:59 +0000, Mark Rutland wrote:
> > xgene_enet_start_xmit
> 
> Please try following trivial fix

With that applied KASAN is silent, despite my efforts to trigger the
issue, so it looks like that fixes it.

Thanks,
Mark.

> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 1adfe7036843..9147a0107c44 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -450,12 +450,12 @@ static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb,
>  		return NETDEV_TX_OK;
>  	}
>  
> -	pdata->ring_ops->wr_cmd(tx_ring, count);
>  	skb_tx_timestamp(skb);
>  
>  	pdata->stats.tx_packets++;
>  	pdata->stats.tx_bytes += skb->len;
>  
> +	pdata->ring_ops->wr_cmd(tx_ring, count);
>  	return NETDEV_TX_OK;
>  }
>  
> 
> 

  reply	other threads:[~2015-11-25 16:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 15:59 KASAN failures in X-Gene ethernet driver in v4.4-rc2 Mark Rutland
2015-11-25 15:59 ` Mark Rutland
2015-11-25 16:17 ` Eric Dumazet
2015-11-25 16:17   ` Eric Dumazet
2015-11-25 16:34   ` Mark Rutland [this message]
2015-11-25 16:34     ` Mark Rutland
2015-11-25 17:02     ` [PATCH net] drivers: net: xgene: fix possible use after free Eric Dumazet
2015-11-25 17:02       ` Eric Dumazet
2015-11-28  3:34       ` Iyappan Subramanian
2015-11-28  3:34         ` Iyappan Subramanian
2015-11-28  3:34         ` Iyappan Subramanian
2015-11-30  3:52       ` David Miller
2015-11-30  3:52         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125163402.GA29094@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.