All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Brian Hutchinson <b.hutchman@gmail.com>,
	fisaksen@baylibre.com
Subject: Re: [PATCH v2 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data
Date: Wed, 25 Nov 2015 10:55:20 -0800	[thread overview]
Message-ID: <20151125185520.GO2517@atomide.com> (raw)
In-Reply-To: <56461001.3050707@baylibre.com>

* Neil Armstrong <narmstrong@baylibre.com> [151113 08:30]:
> Add missing HWMOD_NO_IDLEST hwmod flag for entries not
> having omap4 clkctrl values.
> The emac0 hwmod flag fixes the davinci_emac driver probe
> since the return of pm_resume() call is now checked.
> 
> This solves the following boot errors :
> [    0.121429] omap_hwmod: l4_ls: _wait_target_ready failed: -16
> [    0.121441] omap_hwmod: l4_ls: cannot be enabled for reset (3)
> [    0.124342] omap_hwmod: l4_hs: _wait_target_ready failed: -16
> [    0.124352] omap_hwmod: l4_hs: cannot be enabled for reset (3)
> [    1.967228] omap_hwmod: emac0: _wait_target_ready failed: -16
> 
> Cc: Brian Hutchinson <b.hutchman@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Thanks for checking the TI tree also in addition to the docs,
applying this one into omap-for-v4.4/fixes.

Tony


> ---
>  arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> index b1288f5..6256052 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = {
>  	.name		= "l4_ls",
>  	.clkdm_name	= "alwon_l3s_clkdm",
>  	.class		= &l4_hwmod_class,
> +	.flags		= HWMOD_NO_IDLEST,
>  };
> 
>  /*
> @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = {
>  	.name		= "l4_hs",
>  	.clkdm_name	= "alwon_l3_med_clkdm",
>  	.class		= &l4_hwmod_class,
> +	.flags		= HWMOD_NO_IDLEST,
>  };
> 
>  /* L3 slow -> L4 ls peripheral interface running at 125MHz */
> @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = {
>  	.name		= "emac0",
>  	.clkdm_name	= "alwon_ethernet_clkdm",
>  	.class		= &dm816x_emac_hwmod_class,
> +	.flags		= HWMOD_NO_IDLEST,
>  };
> 
>  static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = {
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data
Date: Wed, 25 Nov 2015 10:55:20 -0800	[thread overview]
Message-ID: <20151125185520.GO2517@atomide.com> (raw)
In-Reply-To: <56461001.3050707@baylibre.com>

* Neil Armstrong <narmstrong@baylibre.com> [151113 08:30]:
> Add missing HWMOD_NO_IDLEST hwmod flag for entries not
> having omap4 clkctrl values.
> The emac0 hwmod flag fixes the davinci_emac driver probe
> since the return of pm_resume() call is now checked.
> 
> This solves the following boot errors :
> [    0.121429] omap_hwmod: l4_ls: _wait_target_ready failed: -16
> [    0.121441] omap_hwmod: l4_ls: cannot be enabled for reset (3)
> [    0.124342] omap_hwmod: l4_hs: _wait_target_ready failed: -16
> [    0.124352] omap_hwmod: l4_hs: cannot be enabled for reset (3)
> [    1.967228] omap_hwmod: emac0: _wait_target_ready failed: -16
> 
> Cc: Brian Hutchinson <b.hutchman@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Thanks for checking the TI tree also in addition to the docs,
applying this one into omap-for-v4.4/fixes.

Tony


> ---
>  arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> index b1288f5..6256052 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> @@ -144,6 +144,7 @@ static struct omap_hwmod dm81xx_l4_ls_hwmod = {
>  	.name		= "l4_ls",
>  	.clkdm_name	= "alwon_l3s_clkdm",
>  	.class		= &l4_hwmod_class,
> +	.flags		= HWMOD_NO_IDLEST,
>  };
> 
>  /*
> @@ -155,6 +156,7 @@ static struct omap_hwmod dm81xx_l4_hs_hwmod = {
>  	.name		= "l4_hs",
>  	.clkdm_name	= "alwon_l3_med_clkdm",
>  	.class		= &l4_hwmod_class,
> +	.flags		= HWMOD_NO_IDLEST,
>  };
> 
>  /* L3 slow -> L4 ls peripheral interface running at 125MHz */
> @@ -850,6 +852,7 @@ static struct omap_hwmod dm816x_emac0_hwmod = {
>  	.name		= "emac0",
>  	.clkdm_name	= "alwon_ethernet_clkdm",
>  	.class		= &dm816x_emac_hwmod_class,
> +	.flags		= HWMOD_NO_IDLEST,
>  };
> 
>  static struct omap_hwmod_ocp_if dm81xx_l4_hs__emac0 = {
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-11-25 18:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 16:29 [PATCH v2 1/4] arm: omap2+: add missing HWMOD_NO_IDLEST in 81xx hwmod data Neil Armstrong
2015-11-13 16:29 ` Neil Armstrong
2015-11-25 18:55 ` Tony Lindgren [this message]
2015-11-25 18:55   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125185520.GO2517@atomide.com \
    --to=tony@atomide.com \
    --cc=b.hutchman@gmail.com \
    --cc=fisaksen@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.