From: Bjorn Helgaas <helgaas@kernel.org>
To: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
lorenzo.pieralisi@arm.com, arnd@arndb.de, bhelgaas@google.com,
robh@kernel.org, linux@arm.linux.org.uk, wangzhou1@hisilicon.com,
liguozhu@hisilicon.com, xuwei5@hisilicon.com
Subject: Re: [PATCH] ARM/PCI: move align_resource function pointer into pci_host_bridge structure
Date: Wed, 25 Nov 2015 13:32:01 -0600 [thread overview]
Message-ID: <20151125193201.GE8869@localhost> (raw)
In-Reply-To: <1447204345-143793-1-git-send-email-gabriele.paoloni@huawei.com>
On Wed, Nov 11, 2015 at 09:12:25AM +0800, Gabriele Paoloni wrote:
> From: gabpao01 <gabriele.paoloni@huawei.com>
>
> commit b3a72384fe29 ("ARM/PCI: Replace
> pci_sys_data->align_resource with global function pointer") has
> introduced a global function pointer that makes the ARM specific
> code not portable and broken in case any platform have a two
> different HW IPs for the PCIe host bridge controller.
> This patch moves align_resource function pointer into
> pci_host_bridge structure so that the code is now suitable to be
> reworked as we want to get rid of hw_pci structure (the host bridge
> drivers can just set the align function pointer in the
> pci_host_bridge structure) and there is no more broken code for a
> SoC with two HW IPs.
>
> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
This looks good to me. I merged b3a72384fe29 so maybe it would make
sense for me to merge this follow-up as well. I put it on my
for-linus branch for v4.4.
If you'd rather merge it via an ARM tree, here's my ack:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
If you want me to merge it, an ARM ack would be nice. If you want to
merge it, let me know and I'll drop it from my tree.
> + /* Resource alignement requirements */
s/alignement/alignment/
> + resource_size_t (*align_resource)(struct pci_dev *dev,
> ...
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM/PCI: move align_resource function pointer into pci_host_bridge structure
Date: Wed, 25 Nov 2015 13:32:01 -0600 [thread overview]
Message-ID: <20151125193201.GE8869@localhost> (raw)
In-Reply-To: <1447204345-143793-1-git-send-email-gabriele.paoloni@huawei.com>
On Wed, Nov 11, 2015 at 09:12:25AM +0800, Gabriele Paoloni wrote:
> From: gabpao01 <gabriele.paoloni@huawei.com>
>
> commit b3a72384fe29 ("ARM/PCI: Replace
> pci_sys_data->align_resource with global function pointer") has
> introduced a global function pointer that makes the ARM specific
> code not portable and broken in case any platform have a two
> different HW IPs for the PCIe host bridge controller.
> This patch moves align_resource function pointer into
> pci_host_bridge structure so that the code is now suitable to be
> reworked as we want to get rid of hw_pci structure (the host bridge
> drivers can just set the align function pointer in the
> pci_host_bridge structure) and there is no more broken code for a
> SoC with two HW IPs.
>
> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
This looks good to me. I merged b3a72384fe29 so maybe it would make
sense for me to merge this follow-up as well. I put it on my
for-linus branch for v4.4.
If you'd rather merge it via an ARM tree, here's my ack:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
If you want me to merge it, an ARM ack would be nice. If you want to
merge it, let me know and I'll drop it from my tree.
> + /* Resource alignement requirements */
s/alignement/alignment/
> + resource_size_t (*align_resource)(struct pci_dev *dev,
> ...
next prev parent reply other threads:[~2015-11-25 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 1:12 [PATCH] ARM/PCI: move align_resource function pointer into pci_host_bridge structure Gabriele Paoloni
2015-11-11 1:12 ` Gabriele Paoloni
2015-11-11 8:47 ` Arnd Bergmann
2015-11-11 8:47 ` Arnd Bergmann
2015-11-11 10:09 ` Gabriele Paoloni
2015-11-11 10:09 ` Gabriele Paoloni
2015-11-25 19:32 ` Bjorn Helgaas [this message]
2015-11-25 19:32 ` Bjorn Helgaas
2015-11-25 19:55 ` Arnd Bergmann
2015-11-25 19:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125193201.GE8869@localhost \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.