From: Stephen Hemminger <stephen@networkplumber.org>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v9 1/9] nfp: basic initialization
Date: Thu, 26 Nov 2015 10:14:49 -0800 [thread overview]
Message-ID: <20151126101449.3f450a14@xeon-e3> (raw)
In-Reply-To: <1448531369-8808-2-git-send-email-alejandro.lucero@netronome.com>
On Thu, 26 Nov 2015 09:49:21 +0000
Alejandro Lucero <alejandro.lucero@netronome.com> wrote:
> +static inline void
> +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val)
> +{
> + uint32_t off;
Minor nit. why mix use of Linux specific basic size typedefs (__u8)
with Posix standard values (uint32_t). The DPDK style is to use
the Posix types except in kernel drivers or code that is coming
from unified drivers (ie ixgbe/base)
next prev parent reply other threads:[~2015-11-26 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 9:49 [PATCH v9 0/9] support for netronome nfp-6xxx card Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 1/9] nfp: basic initialization Alejandro Lucero
2015-11-26 18:14 ` Stephen Hemminger [this message]
2015-11-27 7:51 ` Alejandro Lucero
2015-11-27 9:18 ` Thomas Monjalon
2015-11-26 9:49 ` [PATCH v9 2/9] nfp: adding rx/tx functionality Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 3/9] nfp: adding rss Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 4/9] nfp: adding stats Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 5/9] nfp: adding link functionality Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 6/9] nfp: adding extra functionality Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 7/9] nfp: link status change interrupt support Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 8/9] nfp: adding nic guide Alejandro Lucero
2015-11-26 9:49 ` [PATCH v9 9/9] nfp: updating maintainers Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126101449.3f450a14@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.