From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rt2x00: type bug in _rt2500usb_register_read()
Date: Thu, 26 Nov 2015 12:36:19 +0000 [thread overview]
Message-ID: <20151126123618.GE7289@mwanda> (raw)
In-Reply-To: <5656F95C.60107@bfs.de>
On Thu, Nov 26, 2015 at 01:21:48PM +0100, walter harms wrote:
> > If the low 16 bits were initialized to zero then this code would only be
> > a problem on big endian systems.
> perhaps, cleaning *value would be sufficient ? Avoiding the need for a tmp var.
>
> *value = 0
> rt2500usb_register_read(rt2x00dev, offset, (u16 *)value);
>
Because if you initialize value then you still have a bug on big endian
systems.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rt2x00: type bug in _rt2500usb_register_read()
Date: Thu, 26 Nov 2015 15:36:19 +0300 [thread overview]
Message-ID: <20151126123618.GE7289@mwanda> (raw)
In-Reply-To: <5656F95C.60107@bfs.de>
On Thu, Nov 26, 2015 at 01:21:48PM +0100, walter harms wrote:
> > If the low 16 bits were initialized to zero then this code would only be
> > a problem on big endian systems.
> perhaps, cleaning *value would be sufficient ? Avoiding the need for a tmp var.
>
> *value = 0
> rt2500usb_register_read(rt2x00dev, offset, (u16 *)value);
>
Because if you initialize value then you still have a bug on big endian
systems.
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-26 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 11:55 [patch] rt2x00: type bug in _rt2500usb_register_read() Dan Carpenter
2015-11-26 11:55 ` Dan Carpenter
2015-11-26 12:21 ` walter harms
2015-11-26 12:21 ` walter harms
2015-11-26 12:36 ` Dan Carpenter [this message]
2015-11-26 12:36 ` Dan Carpenter
2015-11-26 13:52 ` Stanislaw Gruszka
2015-11-26 13:52 ` Stanislaw Gruszka
2015-11-30 12:58 ` Kalle Valo
2015-11-30 12:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126123618.GE7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=helmut.schaa@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.