From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Gregory Clement <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH 2/3] clk: add Dove PLL divider support for GPU, VMeta and AXI clocks
Date: Fri, 27 Nov 2015 21:10:08 +0100 [thread overview]
Message-ID: <20151127201008.GD14645@lunn.ch> (raw)
In-Reply-To: <E1a24wo-0004j2-Vd@rmk-PC.arm.linux.org.uk>
Hi Russell
> +static int dove_calc_divider(const struct dove_clk *dc, unsigned long rate,
> + unsigned long parent_rate, bool set)
> +{
> + unsigned int divider, max;
> +
> + divider = DIV_ROUND_CLOSEST(parent_rate, rate);
> +
> + if (dc->divider_table) {
> + unsigned int i;
> +
> + for (i = 0; dc->divider_table[i]; i++)
> + if (divider == dc->divider_table[i]) {
> + divider = i;
> + break;
> + }
> +
> + if (dc->divider_table[i])
> + return -EINVAL;
Is this condition correct? If we have reached the 0 at the end of the
table, -EINVAL makes sense. But that would need a !
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clk: add Dove PLL divider support for GPU, VMeta and AXI clocks
Date: Fri, 27 Nov 2015 21:10:08 +0100 [thread overview]
Message-ID: <20151127201008.GD14645@lunn.ch> (raw)
In-Reply-To: <E1a24wo-0004j2-Vd@rmk-PC.arm.linux.org.uk>
Hi Russell
> +static int dove_calc_divider(const struct dove_clk *dc, unsigned long rate,
> + unsigned long parent_rate, bool set)
> +{
> + unsigned int divider, max;
> +
> + divider = DIV_ROUND_CLOSEST(parent_rate, rate);
> +
> + if (dc->divider_table) {
> + unsigned int i;
> +
> + for (i = 0; dc->divider_table[i]; i++)
> + if (divider == dc->divider_table[i]) {
> + divider = i;
> + break;
> + }
> +
> + if (dc->divider_table[i])
> + return -EINVAL;
Is this condition correct? If we have reached the 0 at the end of the
table, -EINVAL makes sense. But that would need a !
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 2/3] clk: add Dove PLL divider support for GPU, VMeta and AXI clocks
Date: Fri, 27 Nov 2015 21:10:08 +0100 [thread overview]
Message-ID: <20151127201008.GD14645@lunn.ch> (raw)
In-Reply-To: <E1a24wo-0004j2-Vd-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
Hi Russell
> +static int dove_calc_divider(const struct dove_clk *dc, unsigned long rate,
> + unsigned long parent_rate, bool set)
> +{
> + unsigned int divider, max;
> +
> + divider = DIV_ROUND_CLOSEST(parent_rate, rate);
> +
> + if (dc->divider_table) {
> + unsigned int i;
> +
> + for (i = 0; dc->divider_table[i]; i++)
> + if (divider == dc->divider_table[i]) {
> + divider = i;
> + break;
> + }
> +
> + if (dc->divider_table[i])
> + return -EINVAL;
Is this condition correct? If we have reached the 0 at the end of the
table, -EINVAL makes sense. But that would need a !
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-27 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 22:23 [PATCH 2/3] clk: add Dove PLL divider support for GPU, VMeta and AXI clocks Russell King
2015-11-26 22:23 ` Russell King
2015-11-26 22:23 ` Russell King
2015-11-27 20:10 ` Andrew Lunn [this message]
2015-11-27 20:10 ` Andrew Lunn
2015-11-27 20:10 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151127201008.GD14645@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.