All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 3/3] perf hists browser: Update nr entries regardless of min percent
Date: Fri, 27 Nov 2015 21:53:51 -0300	[thread overview]
Message-ID: <20151128005351.GL5934@kernel.org> (raw)
In-Reply-To: <1448645559-31167-3-git-send-email-namhyung@kernel.org>

Em Sat, Nov 28, 2015 at 02:32:39AM +0900, Namhyung Kim escreveu:
> When perf report on TUI was called with -S symbol filter, it should
> update nr entries even if min_pcnt is 0.  IIRC the reason was to update
> nr entries after applying minimum percent threshold.  But if symbol
> filter was given on command line (with -S option), it should use
> hists->nr_non_filtered_entries instead of hists->nr_entries.
> 
> So this patch fixes a bug of navigating hists browser that the cursor
> goes beyond the number of entries when -S (or similar) option is used.

Thanks, tested and applied.

- Arnaldo

  reply	other threads:[~2015-11-28  0:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 17:32 [PATCH 1/3] perf report: Show error message when processing sample fails Namhyung Kim
2015-11-27 17:32 ` [PATCH 2/3] perf hist: Do not skip elided fields when processing samples Namhyung Kim
2015-11-28  0:51   ` Arnaldo Carvalho de Melo
2015-11-29  7:56   ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2015-11-27 17:32 ` [PATCH 3/3] perf hists browser: Update nr entries regardless of min percent Namhyung Kim
2015-11-28  0:53   ` Arnaldo Carvalho de Melo [this message]
2015-11-29  7:56   ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-11-27 19:56 ` [PATCH 1/3] perf report: Show error message when processing sample fails Arnaldo Carvalho de Melo
2015-11-27 19:57   ` Arnaldo Carvalho de Melo
2015-11-28  1:48     ` Namhyung Kim
2015-11-29  7:56 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151128005351.GL5934@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.