From: Viresh Kumar <viresh.kumar@linaro.org>
To: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Kurtz <djkurtz@chromium.org>,
linux-mediatek@lists.infradead.org,
linaro-kernel@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/4] cpufreq: mt8173: remove redundant regulator_get_voltage() call
Date: Mon, 30 Nov 2015 10:53:09 +0530 [thread overview]
Message-ID: <20151130052309.GJ3373@ubuntu> (raw)
In-Reply-To: <1448785898-17838-2-git-send-email-pi-cheng.chen@linaro.org>
On 29-11-15, 16:31, Pi-Cheng Chen wrote:
> Remove redundant regulator_get_voltage() call to get Vsram value
> since it will be obtained later at the beginning of voltage tracking
> loop.
>
> Signed-off-by: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
> ---
> drivers/cpufreq/mt8173-cpufreq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c
> index c438109..750cda7 100644
> --- a/drivers/cpufreq/mt8173-cpufreq.c
> +++ b/drivers/cpufreq/mt8173-cpufreq.c
> @@ -59,7 +59,6 @@ static int mtk_cpufreq_voltage_tracking(struct mtk_cpu_dvfs_info *info,
> int old_vproc, old_vsram, new_vsram, vsram, vproc, ret;
>
> old_vproc = regulator_get_voltage(proc_reg);
> - old_vsram = regulator_get_voltage(sram_reg);
> /* Vsram should not exceed the maximum allowed voltage of SoC. */
> new_vsram = min(new_vproc + MIN_VOLT_SHIFT, MAX_VOLT_LIMIT);
>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] cpufreq: mt8173: remove redundant regulator_get_voltage() call
Date: Mon, 30 Nov 2015 10:53:09 +0530 [thread overview]
Message-ID: <20151130052309.GJ3373@ubuntu> (raw)
In-Reply-To: <1448785898-17838-2-git-send-email-pi-cheng.chen@linaro.org>
On 29-11-15, 16:31, Pi-Cheng Chen wrote:
> Remove redundant regulator_get_voltage() call to get Vsram value
> since it will be obtained later at the beginning of voltage tracking
> loop.
>
> Signed-off-by: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
> ---
> drivers/cpufreq/mt8173-cpufreq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c
> index c438109..750cda7 100644
> --- a/drivers/cpufreq/mt8173-cpufreq.c
> +++ b/drivers/cpufreq/mt8173-cpufreq.c
> @@ -59,7 +59,6 @@ static int mtk_cpufreq_voltage_tracking(struct mtk_cpu_dvfs_info *info,
> int old_vproc, old_vsram, new_vsram, vsram, vproc, ret;
>
> old_vproc = regulator_get_voltage(proc_reg);
> - old_vsram = regulator_get_voltage(sram_reg);
> /* Vsram should not exceed the maximum allowed voltage of SoC. */
> new_vsram = min(new_vproc + MIN_VOLT_SHIFT, MAX_VOLT_LIMIT);
>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2015-11-30 5:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 8:31 [PATCH 1/4] cpufreq: mt8173: add CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag Pi-Cheng Chen
2015-11-29 8:31 ` Pi-Cheng Chen
2015-11-29 8:31 ` [PATCH 2/4] cpufreq: mt8173: remove redundant regulator_get_voltage() call Pi-Cheng Chen
2015-11-29 8:31 ` Pi-Cheng Chen
2015-11-30 5:23 ` Viresh Kumar [this message]
2015-11-30 5:23 ` Viresh Kumar
2015-11-29 8:31 ` [PATCH 3/4] cpufreq: mt8173: check return value of " Pi-Cheng Chen
2015-11-29 8:31 ` Pi-Cheng Chen
2015-11-30 5:27 ` Viresh Kumar
2015-11-30 5:27 ` Viresh Kumar
2015-11-29 8:31 ` [PATCH 4/4] cpufreq: mt8173: move resources allocation into ->probe() Pi-Cheng Chen
2015-11-29 8:31 ` Pi-Cheng Chen
2015-12-05 6:01 ` [PATCH v2] " Pi-Cheng Chen
2015-12-05 6:01 ` Pi-Cheng Chen
2015-12-06 2:24 ` Viresh Kumar
2015-12-06 2:24 ` Viresh Kumar
2015-12-07 2:44 ` Daniel Kurtz
2015-12-07 2:44 ` Daniel Kurtz
2015-12-07 12:42 ` Pi-Cheng Chen
2015-12-07 12:42 ` Pi-Cheng Chen
2015-12-07 16:03 ` Viresh Kumar
2015-12-07 16:03 ` Viresh Kumar
2015-12-09 23:53 ` Rafael J. Wysocki
2015-12-09 23:53 ` Rafael J. Wysocki
2015-12-10 3:48 ` [PATCH v3] " Pi-Cheng Chen
2015-12-10 3:48 ` Pi-Cheng Chen
2015-12-14 23:59 ` Rafael J. Wysocki
2015-12-14 23:59 ` Rafael J. Wysocki
2015-11-30 5:20 ` [PATCH 1/4] cpufreq: mt8173: add CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag Viresh Kumar
2015-11-30 5:20 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130052309.GJ3373@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=djkurtz@chromium.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pi-cheng.chen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.