From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ricky Liang <jcliang@chromium.org>
Cc: Pi-Cheng Chen <pi-cheng.chen@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linaro-kernel@lists.linaro.org,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-arm-kernel@lists.infradead.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/4] cpufreq: mt8173: move resources allocation into ->probe()
Date: Mon, 30 Nov 2015 11:02:06 +0530 [thread overview]
Message-ID: <20151130053206.GL3373@ubuntu> (raw)
In-Reply-To: <CAAJzSMeYKGLkVoh0_zPLpVekQpc2rR5ud9YNCPJxRaJRCNX2nQ@mail.gmail.com>
On 30-11-15, 11:02, Ricky Liang wrote:
> On Sun, Nov 29, 2015 at 4:31 PM, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
> > ret = cpufreq_register_driver(&mt8173_cpufreq_driver);
> > if (ret)
> > pr_err("failed to register mtk cpufreq driver\n");
>
> I think you want "return ret;" inside the if block.
Not just that, he needs to jump to release_dvfs_info_list.
> >
> > + return 0;
> > +
> > +release_dvfs_info_list:
> > + list_for_each_safe(list, tmp, &dvfs_info_list) {
> > + info = list_entry(list, struct mtk_cpu_dvfs_info, list_head);
> > +
> > + mtk_cpu_dvfs_info_release(info);
> > + list_del(list);
> > + kfree(info);
> > + }
> > +
> > return ret;
> > }
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] cpufreq: mt8173: move resources allocation into ->probe()
Date: Mon, 30 Nov 2015 11:02:06 +0530 [thread overview]
Message-ID: <20151130053206.GL3373@ubuntu> (raw)
In-Reply-To: <CAAJzSMeYKGLkVoh0_zPLpVekQpc2rR5ud9YNCPJxRaJRCNX2nQ@mail.gmail.com>
On 30-11-15, 11:02, Ricky Liang wrote:
> On Sun, Nov 29, 2015 at 4:31 PM, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
> > ret = cpufreq_register_driver(&mt8173_cpufreq_driver);
> > if (ret)
> > pr_err("failed to register mtk cpufreq driver\n");
>
> I think you want "return ret;" inside the if block.
Not just that, he needs to jump to release_dvfs_info_list.
> >
> > + return 0;
> > +
> > +release_dvfs_info_list:
> > + list_for_each_safe(list, tmp, &dvfs_info_list) {
> > + info = list_entry(list, struct mtk_cpu_dvfs_info, list_head);
> > +
> > + mtk_cpu_dvfs_info_release(info);
> > + list_del(list);
> > + kfree(info);
> > + }
> > +
> > return ret;
> > }
--
viresh
next prev parent reply other threads:[~2015-11-30 5:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 3:02 [PATCH 4/4] cpufreq: mt8173: move resources allocation into ->probe() Ricky Liang
2015-11-30 5:32 ` Viresh Kumar [this message]
2015-11-30 5:32 ` Viresh Kumar
2015-11-30 14:38 ` Pi-Cheng Chen
2015-11-30 14:38 ` Pi-Cheng Chen
-- strict thread matches above, loose matches on Subject: below --
2015-11-29 8:31 [PATCH 1/4] cpufreq: mt8173: add CPUFREQ_HAVE_GOVERNOR_PER_POLICY flag Pi-Cheng Chen
2015-11-29 8:31 ` [PATCH 4/4] cpufreq: mt8173: move resources allocation into ->probe() Pi-Cheng Chen
2015-11-29 8:31 ` Pi-Cheng Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130053206.GL3373@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=jcliang@chromium.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pi-cheng.chen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.