From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vhost: replace % with & on data path
Date: Mon, 30 Nov 2015 11:21:32 +0200 [thread overview]
Message-ID: <20151130112043-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1448872969.3032.1.camel@perches.com>
On Mon, Nov 30, 2015 at 12:42:49AM -0800, Joe Perches wrote:
> On Mon, 2015-11-30 at 10:34 +0200, Michael S. Tsirkin wrote:
> > We know vring num is a power of 2, so use &
> > to mask the high bits.
> []
> > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> []
> > @@ -1366,10 +1366,12 @@ int vhost_get_vq_desc(struct vhost_virtqueue *vq,
> > /* Only get avail ring entries after they have been exposed by guest. */
> > smp_rmb();
> >
> > + }
>
> ?
Yes, I noticed this - I moved this chunk from the next patch
in my tree by mistake.
Will fix, thanks!
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] vhost: replace % with & on data path
Date: Mon, 30 Nov 2015 11:21:32 +0200 [thread overview]
Message-ID: <20151130112043-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1448872969.3032.1.camel@perches.com>
On Mon, Nov 30, 2015 at 12:42:49AM -0800, Joe Perches wrote:
> On Mon, 2015-11-30 at 10:34 +0200, Michael S. Tsirkin wrote:
> > We know vring num is a power of 2, so use &
> > to mask the high bits.
> []
> > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> []
> > @@ -1366,10 +1366,12 @@ int vhost_get_vq_desc(struct vhost_virtqueue *vq,
> > /* Only get avail ring entries after they have been exposed by guest. */
> > smp_rmb();
> >
> > + }
>
> ?
Yes, I noticed this - I moved this chunk from the next patch
in my tree by mistake.
Will fix, thanks!
--
MST
next prev parent reply other threads:[~2015-11-30 9:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 8:34 [PATCH] vhost: replace % with & on data path Michael S. Tsirkin
2015-11-30 8:34 ` Michael S. Tsirkin
2015-11-30 8:42 ` Joe Perches
2015-11-30 8:42 ` Joe Perches
2015-11-30 9:21 ` Michael S. Tsirkin [this message]
2015-11-30 9:21 ` Michael S. Tsirkin
2015-11-30 9:00 ` kbuild test robot
2015-11-30 9:00 ` kbuild test robot
2015-11-30 9:05 ` kbuild test robot
2015-11-30 9:05 ` kbuild test robot
2015-11-30 9:11 ` Michael S. Tsirkin
2015-11-30 9:11 ` Michael S. Tsirkin
2015-11-30 9:18 ` kbuild test robot
2015-11-30 9:18 ` kbuild test robot
2015-11-30 16:13 ` David Miller
2015-11-30 16:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130112043-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.