From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Huaitong Han <huaitong.han@intel.com>
Subject: Re: [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes
Date: Mon, 30 Nov 2015 12:14:59 -0200 [thread overview]
Message-ID: <20151130141459.GD23717@thinpad.lan.raisama.net> (raw)
In-Reply-To: <565C3133.2060707@redhat.com>
On Mon, Nov 30, 2015 at 12:21:23PM +0100, Paolo Bonzini wrote:
>
>
> On 28/11/2015 20:56, Eduardo Habkost wrote:
> > I still need to figure out a way to write unit tests for the new
> > code. Maybe I will just copy and paste the new and old functions,
> > and test them locally (checking if they give the same results
> > when translating blobs of random bytes).
>
> Aren't the QEMU_BUILD_BUG_ON enough? No need to delete them in patch 3,
> though perhaps you can remove the #defines.
Just wanted to be 100% sure. Even if the offets are all correct,
I might have made other mistakes when translating the get/save
code.
About the QEMU_BUILD_BUG_ON lines, we can keep them if you like.
We could translate the uint32_t offsets to byte offsets after
ptach 3/3, to make them easier to compare to the Intel docs.
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Huaitong Han <huaitong.han@intel.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes
Date: Mon, 30 Nov 2015 12:14:59 -0200 [thread overview]
Message-ID: <20151130141459.GD23717@thinpad.lan.raisama.net> (raw)
In-Reply-To: <565C3133.2060707@redhat.com>
On Mon, Nov 30, 2015 at 12:21:23PM +0100, Paolo Bonzini wrote:
>
>
> On 28/11/2015 20:56, Eduardo Habkost wrote:
> > I still need to figure out a way to write unit tests for the new
> > code. Maybe I will just copy and paste the new and old functions,
> > and test them locally (checking if they give the same results
> > when translating blobs of random bytes).
>
> Aren't the QEMU_BUILD_BUG_ON enough? No need to delete them in patch 3,
> though perhaps you can remove the #defines.
Just wanted to be 100% sure. Even if the offets are all correct,
I might have made other mistakes when translating the get/save
code.
About the QEMU_BUILD_BUG_ON lines, we can keep them if you like.
We could translate the uint32_t offsets to byte offsets after
ptach 3/3, to make them easier to compare to the Intel docs.
--
Eduardo
next prev parent reply other threads:[~2015-11-30 14:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 19:56 [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Eduardo Habkost
2015-11-28 19:56 ` [Qemu-devel] " Eduardo Habkost
2015-11-28 19:56 ` [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area Eduardo Habkost
2015-11-28 19:56 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 11:18 ` Paolo Bonzini
2015-11-30 11:18 ` [Qemu-devel] " Paolo Bonzini
2015-11-30 14:48 ` Eduardo Habkost
2015-11-30 14:48 ` [Qemu-devel] " Eduardo Habkost
2015-12-01 17:09 ` Richard Henderson
2015-12-01 17:15 ` Eduardo Habkost
2015-12-01 17:15 ` Eduardo Habkost
2015-12-01 17:20 ` Richard Henderson
2015-12-01 17:20 ` Richard Henderson
2015-12-01 17:27 ` Paolo Bonzini
2015-12-01 17:27 ` Paolo Bonzini
2015-12-01 18:34 ` Eduardo Habkost
2015-12-01 18:34 ` Eduardo Habkost
2015-12-01 18:42 ` Richard Henderson
2015-12-01 18:42 ` Richard Henderson
2015-11-28 19:56 ` [for-2.6 PATCH 2/3] target-i386: Use xsave structs for ext_save_area Eduardo Habkost
2015-11-28 19:56 ` [Qemu-devel] " Eduardo Habkost
2015-11-28 19:56 ` [for-2.6 PATCH 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load Eduardo Habkost
2015-11-28 19:56 ` [Qemu-devel] " Eduardo Habkost
2015-11-30 11:21 ` [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Paolo Bonzini
2015-11-30 11:21 ` [Qemu-devel] " Paolo Bonzini
2015-11-30 14:14 ` Eduardo Habkost [this message]
2015-11-30 14:14 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130141459.GD23717@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=huaitong.han@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.