All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Brian Hutchinson <b.hutchman@gmail.com>,
	fisaksen@baylibre.com
Subject: Re: [PATCH 4/4] arm: omap2+: Add hwmod spinbox support for dm816x
Date: Mon, 30 Nov 2015 10:08:42 -0800	[thread overview]
Message-ID: <20151130180841.GH2517@atomide.com> (raw)
In-Reply-To: <5628AA03.8080802@baylibre.com>

* Neil Armstrong <narmstrong@baylibre.com> [151022 02:19]:
> Add dm81xx hwmod data entries for dm816x spinbox support.

Looks good to me, I'll apply patches 3 and 4 in this series into
omap-for-v4.5/soc thanks.

Tony

> Cc: Brian Hutchinson <b.hutchman@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 35 ++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> index 6256052..275b16c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> @@ -1036,6 +1036,40 @@ static struct omap_hwmod_ocp_if dm81xx_l4_ls__mailbox = {
>  	.user		= OCP_USER_MPU,
>  };
> 
> +static struct omap_hwmod_class_sysconfig dm81xx_spinbox_sysc = {
> +	.rev_offs	= 0x000,
> +	.sysc_offs	= 0x010,
> +	.syss_offs	= 0x014,
> +	.sysc_flags	= SYSC_HAS_CLOCKACTIVITY | SYSC_HAS_SIDLEMODE |
> +				SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE,
> +	.idlemodes	= SIDLE_FORCE | SIDLE_NO | SIDLE_SMART,
> +	.sysc_fields	= &omap_hwmod_sysc_type1,
> +};
> +
> +static struct omap_hwmod_class dm81xx_spinbox_hwmod_class = {
> +	.name = "spinbox",
> +	.sysc = &dm81xx_spinbox_sysc,
> +};
> +
> +static struct omap_hwmod dm81xx_spinbox_hwmod = {
> +	.name		= "spinbox",
> +	.clkdm_name	= "alwon_l3s_clkdm",
> +	.class		= &dm81xx_spinbox_hwmod_class,
> +	.main_clk	= "sysclk6_ck",
> +	.prcm		= {
> +		.omap4 = {
> +			.clkctrl_offs = DM81XX_CM_ALWON_SPINBOX_CLKCTRL,
> +			.modulemode = MODULEMODE_SWCTRL,
> +		},
> +	},
> +};
> +
> +static struct omap_hwmod_ocp_if dm81xx_l4_ls__spinbox = {
> +	.master		= &dm81xx_l4_ls_hwmod,
> +	.slave		= &dm81xx_spinbox_hwmod,
> +	.user		= OCP_USER_MPU,
> +};
> +
>  static struct omap_hwmod_class dm81xx_tpcc_hwmod_class = {
>  	.name		= "tpcc",
>  };
> @@ -1298,6 +1332,7 @@ static struct omap_hwmod_ocp_if *dm816x_hwmod_ocp_ifs[] __initdata = {
>  	&dm816x_l4_ls__timer7,
>  	&dm81xx_l4_ls__mcspi1,
>  	&dm81xx_l4_ls__mailbox,
> +	&dm81xx_l4_ls__spinbox,
>  	&dm81xx_l4_hs__emac0,
>  	&dm81xx_emac0__mdio,
>  	&dm816x_l4_hs__emac1,
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] arm: omap2+: Add hwmod spinbox support for dm816x
Date: Mon, 30 Nov 2015 10:08:42 -0800	[thread overview]
Message-ID: <20151130180841.GH2517@atomide.com> (raw)
In-Reply-To: <5628AA03.8080802@baylibre.com>

* Neil Armstrong <narmstrong@baylibre.com> [151022 02:19]:
> Add dm81xx hwmod data entries for dm816x spinbox support.

Looks good to me, I'll apply patches 3 and 4 in this series into
omap-for-v4.5/soc thanks.

Tony

> Cc: Brian Hutchinson <b.hutchman@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 35 ++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> index 6256052..275b16c 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c
> @@ -1036,6 +1036,40 @@ static struct omap_hwmod_ocp_if dm81xx_l4_ls__mailbox = {
>  	.user		= OCP_USER_MPU,
>  };
> 
> +static struct omap_hwmod_class_sysconfig dm81xx_spinbox_sysc = {
> +	.rev_offs	= 0x000,
> +	.sysc_offs	= 0x010,
> +	.syss_offs	= 0x014,
> +	.sysc_flags	= SYSC_HAS_CLOCKACTIVITY | SYSC_HAS_SIDLEMODE |
> +				SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE,
> +	.idlemodes	= SIDLE_FORCE | SIDLE_NO | SIDLE_SMART,
> +	.sysc_fields	= &omap_hwmod_sysc_type1,
> +};
> +
> +static struct omap_hwmod_class dm81xx_spinbox_hwmod_class = {
> +	.name = "spinbox",
> +	.sysc = &dm81xx_spinbox_sysc,
> +};
> +
> +static struct omap_hwmod dm81xx_spinbox_hwmod = {
> +	.name		= "spinbox",
> +	.clkdm_name	= "alwon_l3s_clkdm",
> +	.class		= &dm81xx_spinbox_hwmod_class,
> +	.main_clk	= "sysclk6_ck",
> +	.prcm		= {
> +		.omap4 = {
> +			.clkctrl_offs = DM81XX_CM_ALWON_SPINBOX_CLKCTRL,
> +			.modulemode = MODULEMODE_SWCTRL,
> +		},
> +	},
> +};
> +
> +static struct omap_hwmod_ocp_if dm81xx_l4_ls__spinbox = {
> +	.master		= &dm81xx_l4_ls_hwmod,
> +	.slave		= &dm81xx_spinbox_hwmod,
> +	.user		= OCP_USER_MPU,
> +};
> +
>  static struct omap_hwmod_class dm81xx_tpcc_hwmod_class = {
>  	.name		= "tpcc",
>  };
> @@ -1298,6 +1332,7 @@ static struct omap_hwmod_ocp_if *dm816x_hwmod_ocp_ifs[] __initdata = {
>  	&dm816x_l4_ls__timer7,
>  	&dm81xx_l4_ls__mcspi1,
>  	&dm81xx_l4_ls__mailbox,
> +	&dm81xx_l4_ls__spinbox,
>  	&dm81xx_l4_hs__emac0,
>  	&dm81xx_emac0__mdio,
>  	&dm816x_l4_hs__emac1,
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-11-30 18:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22  9:18 [PATCH 4/4] arm: omap2+: Add hwmod spinbox support for dm816x Neil Armstrong
2015-10-22  9:18 ` Neil Armstrong
2015-11-30 18:08 ` Tony Lindgren [this message]
2015-11-30 18:08   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130180841.GH2517@atomide.com \
    --to=tony@atomide.com \
    --cc=b.hutchman@gmail.com \
    --cc=fisaksen@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.