From: Tony Lindgren <tony@atomide.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Grant Erickson <marathon96@gmail.com>, NeilBrown <neilb@suse.de>,
Joachim Eastwood <manabian@gmail.com>
Subject: Re: [PATCH 3/3] arm: plat-omap: Add PWM dmtimer platform data quirks
Date: Mon, 30 Nov 2015 10:37:07 -0800 [thread overview]
Message-ID: <20151130183707.GK2517@atomide.com> (raw)
In-Reply-To: <56374592.4060201@baylibre.com>
* Neil Armstrong <narmstrong@baylibre.com> [151102 03:14]:
> In order to set the currently platform dependent dmtimer
> functions pointers as platform data for the pwm-omap-dmtimer
> platform driver, add it to plat-omap auxdata_lookup table.
>
> Suggested-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Actually this one will need to wait for Thierry to merge the driver
first because of the dependency to the platform_data. Please resend
this one separately once the driver hits the mainline tree.
Regards,
Tony
> ---
> arch/arm/mach-omap2/pdata-quirks.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c
> index ea56397..647dec5 100644
> --- a/arch/arm/mach-omap2/pdata-quirks.c
> +++ b/arch/arm/mach-omap2/pdata-quirks.c
> @@ -23,6 +23,8 @@
> #include <linux/platform_data/pinctrl-single.h>
> #include <linux/platform_data/iommu-omap.h>
> #include <linux/platform_data/wkup_m3.h>
> +#include <linux/platform_data/pwm_omap_dmtimer.h>
> +#include <plat/dmtimer.h>
>
> #include <asm/siginfo.h>
> #include <asm/signal.h>
> @@ -453,6 +455,24 @@ void omap_auxdata_legacy_init(struct device *dev)
> dev->platform_data = &twl_gpio_auxdata;
> }
>
> +/* Dual mode timer PWM callbacks platdata */
> +#if IS_ENABLED(CONFIG_OMAP_DM_TIMER)
> +struct pwm_omap_dmtimer_pdata pwm_dmtimer_pdata = {
> + .request_by_node = omap_dm_timer_request_by_node,
> + .free = omap_dm_timer_free,
> + .enable = omap_dm_timer_enable,
> + .disable = omap_dm_timer_disable,
> + .get_fclk = omap_dm_timer_get_fclk,
> + .start = omap_dm_timer_start,
> + .stop = omap_dm_timer_stop,
> + .set_load = omap_dm_timer_set_load,
> + .set_match = omap_dm_timer_set_match,
> + .set_pwm = omap_dm_timer_set_pwm,
> + .set_prescaler = omap_dm_timer_set_prescaler,
> + .write_counter = omap_dm_timer_write_counter,
> +};
> +#endif
> +
> /*
> * Few boards still need auxdata populated before we populate
> * the dev entries in of_platform_populate().
> @@ -506,6 +526,9 @@ static struct of_dev_auxdata omap_auxdata_lookup[] __initdata = {
> OF_DEV_AUXDATA("ti,am4372-wkup-m3", 0x44d00000, "44d00000.wkup_m3",
> &wkup_m3_data),
> #endif
> +#if IS_ENABLED(CONFIG_OMAP_DM_TIMER)
> + OF_DEV_AUXDATA("ti,omap-dmtimer-pwm", 0, NULL, &pwm_dmtimer_pdata),
> +#endif
> #if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5)
> OF_DEV_AUXDATA("ti,omap4-iommu", 0x4a066000, "4a066000.mmu",
> &omap4_iommu_pdata),
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] arm: plat-omap: Add PWM dmtimer platform data quirks
Date: Mon, 30 Nov 2015 10:37:07 -0800 [thread overview]
Message-ID: <20151130183707.GK2517@atomide.com> (raw)
In-Reply-To: <56374592.4060201@baylibre.com>
* Neil Armstrong <narmstrong@baylibre.com> [151102 03:14]:
> In order to set the currently platform dependent dmtimer
> functions pointers as platform data for the pwm-omap-dmtimer
> platform driver, add it to plat-omap auxdata_lookup table.
>
> Suggested-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Actually this one will need to wait for Thierry to merge the driver
first because of the dependency to the platform_data. Please resend
this one separately once the driver hits the mainline tree.
Regards,
Tony
> ---
> arch/arm/mach-omap2/pdata-quirks.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c
> index ea56397..647dec5 100644
> --- a/arch/arm/mach-omap2/pdata-quirks.c
> +++ b/arch/arm/mach-omap2/pdata-quirks.c
> @@ -23,6 +23,8 @@
> #include <linux/platform_data/pinctrl-single.h>
> #include <linux/platform_data/iommu-omap.h>
> #include <linux/platform_data/wkup_m3.h>
> +#include <linux/platform_data/pwm_omap_dmtimer.h>
> +#include <plat/dmtimer.h>
>
> #include <asm/siginfo.h>
> #include <asm/signal.h>
> @@ -453,6 +455,24 @@ void omap_auxdata_legacy_init(struct device *dev)
> dev->platform_data = &twl_gpio_auxdata;
> }
>
> +/* Dual mode timer PWM callbacks platdata */
> +#if IS_ENABLED(CONFIG_OMAP_DM_TIMER)
> +struct pwm_omap_dmtimer_pdata pwm_dmtimer_pdata = {
> + .request_by_node = omap_dm_timer_request_by_node,
> + .free = omap_dm_timer_free,
> + .enable = omap_dm_timer_enable,
> + .disable = omap_dm_timer_disable,
> + .get_fclk = omap_dm_timer_get_fclk,
> + .start = omap_dm_timer_start,
> + .stop = omap_dm_timer_stop,
> + .set_load = omap_dm_timer_set_load,
> + .set_match = omap_dm_timer_set_match,
> + .set_pwm = omap_dm_timer_set_pwm,
> + .set_prescaler = omap_dm_timer_set_prescaler,
> + .write_counter = omap_dm_timer_write_counter,
> +};
> +#endif
> +
> /*
> * Few boards still need auxdata populated before we populate
> * the dev entries in of_platform_populate().
> @@ -506,6 +526,9 @@ static struct of_dev_auxdata omap_auxdata_lookup[] __initdata = {
> OF_DEV_AUXDATA("ti,am4372-wkup-m3", 0x44d00000, "44d00000.wkup_m3",
> &wkup_m3_data),
> #endif
> +#if IS_ENABLED(CONFIG_OMAP_DM_TIMER)
> + OF_DEV_AUXDATA("ti,omap-dmtimer-pwm", 0, NULL, &pwm_dmtimer_pdata),
> +#endif
> #if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5)
> OF_DEV_AUXDATA("ti,omap4-iommu", 0x4a066000, "4a066000.mmu",
> &omap4_iommu_pdata),
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-11-30 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 11:14 [PATCH 3/3] arm: plat-omap: Add PWM dmtimer platform data quirks Neil Armstrong
2015-11-02 11:14 ` Neil Armstrong
2015-11-30 18:37 ` Tony Lindgren [this message]
2015-11-30 18:37 ` Tony Lindgren
2016-01-22 16:15 ` [PATCH repost] " Neil Armstrong
2016-01-22 16:15 ` Neil Armstrong
2016-01-25 18:08 ` Tony Lindgren
2016-01-25 18:08 ` Tony Lindgren
2016-01-26 8:44 ` Neil Armstrong
2016-01-26 8:44 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130183707.GK2517@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=marathon96@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=neilb@suse.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.