From: Eduardo Valentin <edubezval@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pm@vger.kernel.org,
Ryusuke Sakato <ryusuke.sakato.bx@renesas.com>,
linux-kernel@vger.kernel.org,
"osd2@lm.renesas.com" <osd2@lm.renesas.com>
Subject: Re: [PATCH] thermal: rcar: add .set_trip_temp support
Date: Mon, 30 Nov 2015 10:51:00 -0800 [thread overview]
Message-ID: <20151130185058.GA5900@localhost.localdomain> (raw)
In-Reply-To: <87a8q28wsv.wl%kuninori.morimoto.gx@renesas.com>
On Wed, Nov 25, 2015 at 05:42:27AM +0000, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> You can set trip temp if your kernel has CONFIG_THERMAL_WRITABLE_TRIPS
>
> echo $temp > /sys/class/thermal/thermal_zone0/trip_point_0_temp
>
> -45000 < $temp < 125000 is supported
> Default is 90000
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> This patch is v2 of "[PATCH] thermal: rcar: enable to set tripN-temp via DT"
> I think it will be full-DT feature if it uses of-thermal, but this driver is used
> from non-DT SoC too. We would like to keep non-DT support.
> And we would like to do is only exchange trip temp.
> .set_trip_temp is very enouth for it at this point.
> But, it can use of-thermal feature in the future.
Kuninori,
According to discussion on your first version [1], this patch is not needed
anymore, right?
If you want to add the support for writable trip points, please, add the
support to of-thermal, as this driver supports only DT booting boards.
[1] - https://lkml.org/lkml/2015/11/25/888
>
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <edubezval@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pm@vger.kernel.org,
Ryusuke Sakato <ryusuke.sakato.bx@renesas.com>,
linux-kernel@vger.kernel.org,
"osd2@lm.renesas.com" <osd2@lm.renesas.com>
Subject: Re: [PATCH] thermal: rcar: add .set_trip_temp support
Date: Mon, 30 Nov 2015 18:51:00 +0000 [thread overview]
Message-ID: <20151130185058.GA5900@localhost.localdomain> (raw)
In-Reply-To: <87a8q28wsv.wl%kuninori.morimoto.gx@renesas.com>
On Wed, Nov 25, 2015 at 05:42:27AM +0000, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> You can set trip temp if your kernel has CONFIG_THERMAL_WRITABLE_TRIPS
>
> echo $temp > /sys/class/thermal/thermal_zone0/trip_point_0_temp
>
> -45000 < $temp < 125000 is supported
> Default is 90000
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> This patch is v2 of "[PATCH] thermal: rcar: enable to set tripN-temp via DT"
> I think it will be full-DT feature if it uses of-thermal, but this driver is used
> from non-DT SoC too. We would like to keep non-DT support.
> And we would like to do is only exchange trip temp.
> .set_trip_temp is very enouth for it at this point.
> But, it can use of-thermal feature in the future.
Kuninori,
According to discussion on your first version [1], this patch is not needed
anymore, right?
If you want to add the support for writable trip points, please, add the
support to of-thermal, as this driver supports only DT booting boards.
[1] - https://lkml.org/lkml/2015/11/25/888
>
next prev parent reply other threads:[~2015-11-30 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 5:42 [PATCH] thermal: rcar: add .set_trip_temp support Kuninori Morimoto
2015-11-25 5:42 ` Kuninori Morimoto
2015-11-30 18:51 ` Eduardo Valentin [this message]
2015-11-30 18:51 ` Eduardo Valentin
2015-12-01 3:00 ` Kuninori Morimoto
2015-12-01 3:00 ` Kuninori Morimoto
2015-12-01 3:00 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130185058.GA5900@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=osd2@lm.renesas.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=ryusuke.sakato.bx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.