From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 4/4] ARM: DRA7: hwmod: Add data for GPTimer 12
Date: Mon, 30 Nov 2015 10:59:53 -0800 [thread overview]
Message-ID: <20151130185953.GM2517@atomide.com> (raw)
In-Reply-To: <1444087704-1429-5-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
* Suman Anna <s-anna-l0cyMroinI0@public.gmane.org> [151005 16:35]:
> Add the hwmod data for GPTimer 12. GPTimer 12 is present in
> WKUPAON power domain and is clocked from a secure 32K clock.
> GPTimer 12 serves as a secure timer on HS devices, but is
> available for kernel on regular GP devices.
>
> The hwmod link is registered only on GP devices. The hwmod data
> also reused the existing timer class instead of reintroducing
> the identical dra7xx_timer_secure_sysc class which was dropped
> in commit edec17863362 ("ARM: DRA7: hwmod: Fix the hwmod class
> for GPTimer4").
>
> Signed-off-by: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Paul should take a look at this one.
Regards,
Tony
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 36 +++++++++++++++++++++++++++++--
> 1 file changed, 34 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247bced49..37a10f87fbcd 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1929,6 +1929,20 @@ static struct omap_hwmod dra7xx_timer11_hwmod = {
> },
> };
>
> +/* timer12 */
> +static struct omap_hwmod dra7xx_timer12_hwmod = {
> + .name = "timer12",
> + .class = &dra7xx_timer_hwmod_class,
> + .clkdm_name = "wkupaon_clkdm",
> + .main_clk = "secure_32k_clk_src_ck",
> + .prcm = {
> + .omap4 = {
> + .clkctrl_offs = DRA7XX_CM_WKUPAON_TIMER12_CLKCTRL_OFFSET,
> + .context_offs = DRA7XX_RM_WKUPAON_TIMER12_CONTEXT_OFFSET,
> + },
> + },
> +};
> +
> /* timer13 */
> static struct omap_hwmod dra7xx_timer13_hwmod = {
> .name = "timer13",
> @@ -3135,6 +3149,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__timer11 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_wkup -> timer12 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_wkup__timer12 = {
> + .master = &dra7xx_l4_wkup_hwmod,
> + .slave = &dra7xx_timer12_hwmod,
> + .clk = "wkupaon_iclk_mux",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_per3 -> timer13 */
> static struct omap_hwmod_ocp_if dra7xx_l4_per3__timer13 = {
> .master = &dra7xx_l4_per3_hwmod,
> @@ -3429,6 +3451,13 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> NULL,
> };
>
> +/* GP-only hwmod links */
> +static struct omap_hwmod_ocp_if *dra7xx_gp_hwmod_ocp_ifs[] __initdata = {
> + &dra7xx_l4_wkup__timer12,
> + NULL,
> +};
> +
> +/* SoC variant specific hwmod links */
> static struct omap_hwmod_ocp_if *dra74x_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per3__usb_otg_ss4,
> NULL,
> @@ -3446,9 +3475,12 @@ int __init dra7xx_hwmod_init(void)
> ret = omap_hwmod_register_links(dra7xx_hwmod_ocp_ifs);
>
> if (!ret && soc_is_dra74x())
> - return omap_hwmod_register_links(dra74x_hwmod_ocp_ifs);
> + ret = omap_hwmod_register_links(dra74x_hwmod_ocp_ifs);
> else if (!ret && soc_is_dra72x())
> - return omap_hwmod_register_links(dra72x_hwmod_ocp_ifs);
> + ret = omap_hwmod_register_links(dra72x_hwmod_ocp_ifs);
> +
> + if (!ret && omap_type() == OMAP2_DEVICE_TYPE_GP)
> + ret = omap_hwmod_register_links(dra7xx_gp_hwmod_ocp_ifs);
>
> return ret;
> }
> --
> 2.6.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ARM: DRA7: hwmod: Add data for GPTimer 12
Date: Mon, 30 Nov 2015 10:59:53 -0800 [thread overview]
Message-ID: <20151130185953.GM2517@atomide.com> (raw)
In-Reply-To: <1444087704-1429-5-git-send-email-s-anna@ti.com>
* Suman Anna <s-anna@ti.com> [151005 16:35]:
> Add the hwmod data for GPTimer 12. GPTimer 12 is present in
> WKUPAON power domain and is clocked from a secure 32K clock.
> GPTimer 12 serves as a secure timer on HS devices, but is
> available for kernel on regular GP devices.
>
> The hwmod link is registered only on GP devices. The hwmod data
> also reused the existing timer class instead of reintroducing
> the identical dra7xx_timer_secure_sysc class which was dropped
> in commit edec17863362 ("ARM: DRA7: hwmod: Fix the hwmod class
> for GPTimer4").
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
Paul should take a look at this one.
Regards,
Tony
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 36 +++++++++++++++++++++++++++++--
> 1 file changed, 34 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247bced49..37a10f87fbcd 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1929,6 +1929,20 @@ static struct omap_hwmod dra7xx_timer11_hwmod = {
> },
> };
>
> +/* timer12 */
> +static struct omap_hwmod dra7xx_timer12_hwmod = {
> + .name = "timer12",
> + .class = &dra7xx_timer_hwmod_class,
> + .clkdm_name = "wkupaon_clkdm",
> + .main_clk = "secure_32k_clk_src_ck",
> + .prcm = {
> + .omap4 = {
> + .clkctrl_offs = DRA7XX_CM_WKUPAON_TIMER12_CLKCTRL_OFFSET,
> + .context_offs = DRA7XX_RM_WKUPAON_TIMER12_CONTEXT_OFFSET,
> + },
> + },
> +};
> +
> /* timer13 */
> static struct omap_hwmod dra7xx_timer13_hwmod = {
> .name = "timer13",
> @@ -3135,6 +3149,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__timer11 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_wkup -> timer12 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_wkup__timer12 = {
> + .master = &dra7xx_l4_wkup_hwmod,
> + .slave = &dra7xx_timer12_hwmod,
> + .clk = "wkupaon_iclk_mux",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_per3 -> timer13 */
> static struct omap_hwmod_ocp_if dra7xx_l4_per3__timer13 = {
> .master = &dra7xx_l4_per3_hwmod,
> @@ -3429,6 +3451,13 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> NULL,
> };
>
> +/* GP-only hwmod links */
> +static struct omap_hwmod_ocp_if *dra7xx_gp_hwmod_ocp_ifs[] __initdata = {
> + &dra7xx_l4_wkup__timer12,
> + NULL,
> +};
> +
> +/* SoC variant specific hwmod links */
> static struct omap_hwmod_ocp_if *dra74x_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per3__usb_otg_ss4,
> NULL,
> @@ -3446,9 +3475,12 @@ int __init dra7xx_hwmod_init(void)
> ret = omap_hwmod_register_links(dra7xx_hwmod_ocp_ifs);
>
> if (!ret && soc_is_dra74x())
> - return omap_hwmod_register_links(dra74x_hwmod_ocp_ifs);
> + ret = omap_hwmod_register_links(dra74x_hwmod_ocp_ifs);
> else if (!ret && soc_is_dra72x())
> - return omap_hwmod_register_links(dra72x_hwmod_ocp_ifs);
> + ret = omap_hwmod_register_links(dra72x_hwmod_ocp_ifs);
> +
> + if (!ret && omap_type() == OMAP2_DEVICE_TYPE_GP)
> + ret = omap_hwmod_register_links(dra7xx_gp_hwmod_ocp_ifs);
>
> return ret;
> }
> --
> 2.6.0
>
next prev parent reply other threads:[~2015-11-30 18:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 23:28 [PATCH v2 0/4] DRA7 Timer12 Support Suman Anna
2015-10-05 23:28 ` Suman Anna
[not found] ` <1444087704-1429-1-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-10-05 23:28 ` [PATCH v2 1/4] ARM: OMAP: dmtimer: check for fixed timers during config Suman Anna
2015-10-05 23:28 ` Suman Anna
2015-10-05 23:28 ` [PATCH v2 2/4] ARM: OMAP2+: timer: Remove secure timer for DRA7xx HS devices Suman Anna
2015-10-05 23:28 ` Suman Anna
2015-10-05 23:28 ` [PATCH v2 3/4] ARM: dts: DRA7: Add timer12 node Suman Anna
2015-10-05 23:28 ` Suman Anna
[not found] ` <1444087704-1429-4-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-10-06 0:47 ` Felipe Balbi
2015-10-06 0:47 ` Felipe Balbi
[not found] ` <87y4fgesbz.fsf-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-10-06 7:52 ` Tony Lindgren
2015-10-06 7:52 ` Tony Lindgren
[not found] ` <20151006075209.GH23801-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-10-06 16:02 ` Suman Anna
2015-10-06 16:02 ` Suman Anna
[not found] ` <5613F09C.1050809-l0cyMroinI0@public.gmane.org>
2015-11-30 18:58 ` Tony Lindgren
2015-11-30 18:58 ` Tony Lindgren
2015-10-05 23:28 ` [PATCH v2 4/4] ARM: DRA7: hwmod: Add data for GPTimer 12 Suman Anna
2015-10-05 23:28 ` Suman Anna
[not found] ` <1444087704-1429-5-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-11-30 18:59 ` Tony Lindgren [this message]
2015-11-30 18:59 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130185953.GM2517@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=s-anna-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.