From: Stephen Boyd <sboyd@codeaurora.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mike Turquette <mturquette@baylibre.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast
Date: Mon, 30 Nov 2015 11:32:16 -0800 [thread overview]
Message-ID: <20151130193216.GI11298@codeaurora.org> (raw)
In-Reply-To: <1448897699-20475-1-git-send-email-maxime.ripard@free-electrons.com>
On 11/30, Maxime Ripard wrote:
> @@ -191,25 +186,17 @@ err_unmap:
> iounmap(reg);
> }
>
> -static struct sun4i_pll2_data sun4i_a10_pll2_data = {
> - .pre_div_flags = CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO,
> -};
> -
> static void __init sun4i_a10_pll2_setup(struct device_node *node)
> {
> - sun4i_pll2_setup(node, &sun4i_a10_pll2_data);
> + sun4i_pll2_setup(node, &sun4i_a10_pll2_data, 0);
And it doesn't compile, because we just deleted the data that
this is taking an address of. Hmph.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: sunxi: pll2: Fix clock running too fast
Date: Mon, 30 Nov 2015 11:32:16 -0800 [thread overview]
Message-ID: <20151130193216.GI11298@codeaurora.org> (raw)
In-Reply-To: <1448897699-20475-1-git-send-email-maxime.ripard@free-electrons.com>
On 11/30, Maxime Ripard wrote:
> @@ -191,25 +186,17 @@ err_unmap:
> iounmap(reg);
> }
>
> -static struct sun4i_pll2_data sun4i_a10_pll2_data = {
> - .pre_div_flags = CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO,
> -};
> -
> static void __init sun4i_a10_pll2_setup(struct device_node *node)
> {
> - sun4i_pll2_setup(node, &sun4i_a10_pll2_data);
> + sun4i_pll2_setup(node, &sun4i_a10_pll2_data, 0);
And it doesn't compile, because we just deleted the data that
this is taking an address of. Hmph.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-11-30 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 15:34 [PATCH] clk: sunxi: pll2: Fix clock running too fast Maxime Ripard
2015-11-30 15:34 ` Maxime Ripard
2015-11-30 19:29 ` Stephen Boyd
2015-11-30 19:29 ` Stephen Boyd
2015-11-30 19:32 ` Stephen Boyd [this message]
2015-11-30 19:32 ` Stephen Boyd
2015-11-30 20:14 ` Maxime Ripard
2015-11-30 20:14 ` Maxime Ripard
2015-11-30 19:42 ` kbuild test robot
2015-11-30 19:42 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130193216.GI11298@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.