From: Brian Norris <computersforpeace@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: cfi: enforce valid geometry configuration
Date: Mon, 30 Nov 2015 12:44:28 -0800 [thread overview]
Message-ID: <20151130204428.GM64635@google.com> (raw)
In-Reply-To: <3747078.dk5V5gxuXa@wuerfel>
On Mon, Nov 23, 2015 at 02:39:33PM +0100, Arnd Bergmann wrote:
> MTD allows compile-time configuration of the possible CFI geometry
> settings that are allowed by the kernel, but that includes a couple of
> invalid configurations, where no bank width or no interleave setting
> is allowed. These are then caught with a compile-time warning:
>
> include/linux/mtd/cfi.h:76:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
> include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
>
> This is a bit annoying for randconfig tests, and can be avoided if
> we change the Kconfig logic to always select the simplest configuration
> when no other one is enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Pushed to l2-mtd.git. Thanks for fixing this one! I guess an ugly fix is
better than nothing here.
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: cfi: enforce valid geometry configuration
Date: Mon, 30 Nov 2015 12:44:28 -0800 [thread overview]
Message-ID: <20151130204428.GM64635@google.com> (raw)
In-Reply-To: <3747078.dk5V5gxuXa@wuerfel>
On Mon, Nov 23, 2015 at 02:39:33PM +0100, Arnd Bergmann wrote:
> MTD allows compile-time configuration of the possible CFI geometry
> settings that are allowed by the kernel, but that includes a couple of
> invalid configurations, where no bank width or no interleave setting
> is allowed. These are then caught with a compile-time warning:
>
> include/linux/mtd/cfi.h:76:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
> include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work"
>
> This is a bit annoying for randconfig tests, and can be avoided if
> we change the Kconfig logic to always select the simplest configuration
> when no other one is enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Pushed to l2-mtd.git. Thanks for fixing this one! I guess an ugly fix is
better than nothing here.
next prev parent reply other threads:[~2015-11-30 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 13:39 [PATCH] mtd: cfi: enforce valid geometry configuration Arnd Bergmann
2015-11-23 13:39 ` Arnd Bergmann
2015-11-23 22:12 ` Arnd Bergmann
2015-11-23 22:12 ` Arnd Bergmann
2015-11-24 22:09 ` [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Arnd Bergmann
2015-11-24 22:09 ` Arnd Bergmann
2015-11-30 20:55 ` Brian Norris
2015-11-30 20:55 ` Brian Norris
2015-11-30 21:41 ` Arnd Bergmann
2015-11-30 21:41 ` Arnd Bergmann
2015-11-30 20:44 ` Brian Norris [this message]
2015-11-30 20:44 ` [PATCH] mtd: cfi: enforce valid geometry configuration Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130204428.GM64635@google.com \
--to=computersforpeace@gmail.com \
--cc=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.