From: Stephen Hemminger <stephen@networkplumber.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC 4/4] i40e: handle per queue rx_usecs setting
Date: Tue, 1 Dec 2015 11:47:26 -0800 [thread overview]
Message-ID: <20151201114726.43d0540c@xeon-e3> (raw)
In-Reply-To: <1448956892-15509-4-git-send-email-kan.liang@intel.com>
On Tue, 1 Dec 2015 08:01:32 +0000
kan.liang at intel.com wrote:
> +u32 i40e_ndo_get_per_queue_rx_usecs(struct net_device *dev, int index)
> +{
> + struct i40e_netdev_priv *np = netdev_priv(dev);
> + struct i40e_vsi *vsi = np->vsi;
> + struct i40e_pf *pf = vsi->back;
> + struct i40e_hw *hw = &pf->hw;
> + u32 val;
> +
> + val = rd32(hw, I40E_PFINT_ITRN(0, index));
> +
> + return (val * 2);
Please don't put useless paren's around return value.
That is a BSD style that is not practiced in Linux.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: kan.liang@intel.com
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
davem@davemloft.net, jesse.brandeburg@intel.com,
andi@firstfloor.org, jeffrey.t.kirsher@intel.com,
shannon.nelson@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, matthew.vick@intel.com,
john.ronciak@intel.com, mitch.a.williams@intel.com,
john.r.fastabend@intel.com, ogerlitz@mellanox.com,
edumazet@google.com, jiri@mellanox.com, sfeldma@gmail.com,
gospo@cumulusnetworks.com, sasha.levin@oracle.com,
f.fainelli@gmail.com, dsahern@gmail.com, tj@kernel.org,
cascardo@redhat.com, corbet@lwn.net
Subject: Re: [RFC 4/4] i40e: handle per queue rx_usecs setting
Date: Tue, 1 Dec 2015 11:47:26 -0800 [thread overview]
Message-ID: <20151201114726.43d0540c@xeon-e3> (raw)
In-Reply-To: <1448956892-15509-4-git-send-email-kan.liang@intel.com>
On Tue, 1 Dec 2015 08:01:32 +0000
kan.liang@intel.com wrote:
> +u32 i40e_ndo_get_per_queue_rx_usecs(struct net_device *dev, int index)
> +{
> + struct i40e_netdev_priv *np = netdev_priv(dev);
> + struct i40e_vsi *vsi = np->vsi;
> + struct i40e_pf *pf = vsi->back;
> + struct i40e_hw *hw = &pf->hw;
> + u32 val;
> +
> + val = rd32(hw, I40E_PFINT_ITRN(0, index));
> +
> + return (val * 2);
Please don't put useless paren's around return value.
That is a BSD style that is not practiced in Linux.
next prev parent reply other threads:[~2015-12-01 19:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 8:01 [Intel-wired-lan] [RFC 1/4] net: support per queue tx_usecs in sysfs kan.liang
2015-12-01 8:01 ` kan.liang
2015-12-01 8:01 ` [Intel-wired-lan] [RFC 2/4] i40e: handle per queue tx_usecs setting kan.liang
2015-12-01 8:01 ` kan.liang
2015-12-01 8:01 ` [Intel-wired-lan] [RFC 3/4] net: support per queue rx_usecs in sysfs kan.liang
2015-12-01 8:01 ` kan.liang
2015-12-01 8:01 ` [Intel-wired-lan] [RFC 4/4] i40e: handle per queue rx_usecs setting kan.liang
2015-12-01 8:01 ` kan.liang
2015-12-01 19:47 ` Stephen Hemminger [this message]
2015-12-01 19:47 ` Stephen Hemminger
2015-12-01 22:13 ` [Intel-wired-lan] [RFC 1/4] net: support per queue tx_usecs in sysfs Florian Fainelli
2015-12-01 22:13 ` Florian Fainelli
2015-12-01 23:44 ` [Intel-wired-lan] " Jesse Brandeburg
2015-12-01 23:44 ` Jesse Brandeburg
2015-12-02 1:57 ` [Intel-wired-lan] " Alexander Duyck
2015-12-02 1:57 ` Alexander Duyck
2015-12-02 2:27 ` [Intel-wired-lan] " David Miller
2015-12-02 2:27 ` David Miller
2015-12-02 2:23 ` [Intel-wired-lan] " David Miller
2015-12-02 2:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201114726.43d0540c@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.