[PATCH v3] uselib: default depending if libc5 was used

[PATCH v3] uselib: default depending if libc5 was used

[Riku Voipio]

uselib hasn't been used since libc5; glibc does not use it.
Deprecate uselib a bit more, by making the default y only
if libc5 was widely used on the plaform.

This makes arm64 kernel built with defconfig slightly smaller

bloat-o-meter:
add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390)
function                                     old     new   delta
kernel_config_data                         18164   18162      -2
uselib_flags                                  20       -     -20
padzero                                      216     192     -24
sys_uselib                                   380       -    -380
load_elf_library                             964       -    -964

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Cc: Josh Triplett <josh@joshtriplett.org>
---
v3: only depend on IA32_EMULATION to catch X86_64 with 32bit case
v2: Disable uselib on X86_64 if no 32bit support
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index c24b6f7..5a7f375 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -285,7 +285,7 @@ config FHANDLE
 
 config USELIB
 	bool "uselib syscall"
-	default y
+	def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION
 	help
 	  This option enables the uselib syscall, a system call used in the
 	  dynamic linker from libc5 and earlier.  glibc does not use this
-- 
2.6.2

Re: [PATCH v3] uselib: default depending if libc5 was used

[Josh Triplett]

On Tue, Dec 01, 2015 at 04:08:57PM +0200, Riku Voipio wrote:
> uselib hasn't been used since libc5; glibc does not use it.
> Deprecate uselib a bit more, by making the default y only
> if libc5 was widely used on the plaform.
> 
> This makes arm64 kernel built with defconfig slightly smaller
> 
> bloat-o-meter:
> add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390)
> function                                     old     new   delta
> kernel_config_data                         18164   18162      -2
> uselib_flags                                  20       -     -20
> padzero                                      216     192     -24
> sys_uselib                                   380       -    -380
> load_elf_library                             964       -    -964
> 
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> Cc: Josh Triplett <josh@joshtriplett.org>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> v3: only depend on IA32_EMULATION to catch X86_64 with 32bit case
> v2: Disable uselib on X86_64 if no 32bit support
>  init/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index c24b6f7..5a7f375 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -285,7 +285,7 @@ config FHANDLE
>  
>  config USELIB
>  	bool "uselib syscall"
> -	default y
> +	def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION
>  	help
>  	  This option enables the uselib syscall, a system call used in the
>  	  dynamic linker from libc5 and earlier.  glibc does not use this
> -- 
> 2.6.2
> 

Re: [PATCH v3] uselib: default depending if libc5 was used

[Geert Uytterhoeven]

On Tue, Dec 1, 2015 at 3:08 PM, Riku Voipio <riku.voipio@linaro.org> wrote:
> uselib hasn't been used since libc5; glibc does not use it.
> Deprecate uselib a bit more, by making the default y only
> if libc5 was widely used on the plaform.
>
> This makes arm64 kernel built with defconfig slightly smaller
>
> bloat-o-meter:
> add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390)
> function                                     old     new   delta
> kernel_config_data                         18164   18162      -2
> uselib_flags                                  20       -     -20
> padzero                                      216     192     -24
> sys_uselib                                   380       -    -380
> load_elf_library                             964       -    -964
>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> Cc: Josh Triplett <josh@joshtriplett.org>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds