From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, Kumar Gala <galak@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: [rtc-linux] Re: [PATCH v2 2/2] rtc: add driver for RX6110SA real time clock
Date: Wed, 2 Dec 2015 14:21:38 +0100 [thread overview]
Message-ID: <20151202132138.GB22136@piout.net> (raw)
In-Reply-To: <20151201194919.GG5072@pengutronix.de>
On 01/12/2015 at 20:49:19 +0100, Uwe Kleine-K=C3=B6nig wrote :
> > Seeing the comment comment above, this should probably be if
> > (tm->tm_year < 100 || tm->tm_year >=3D 200)
> > I don't think this particular part has any issue
> > handling 2038. However, on 32bit platform, your userspace is probably
> > not ready to handle those date. hwclock should return the correct date.
>=20
> userspace is not ready because it cannot. Before this can be addressed,
> quite some things need fixing first. If I understood correctly timerfd
> for example is broken which completely locks up systemd.
>=20
> Note this doesn't justify to not write a date later than 2037 in the rtc
> driver however. Still thinking about how to handle this for the machines
> we work on, we thought about letting the RTC_RD_TIME ioctl fail for
> dates later than 2038 to work around this issue.
>=20
Yeah but the rtc doesn't have any issue handling dates after 2038 so if
it is used on a 64bit system, it can work properly until february 2100.
Also, I'm not sure how that solves your problem anyway.
--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Steffen Trumtrar
<s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Subject: Re: [PATCH v2 2/2] rtc: add driver for RX6110SA real time clock
Date: Wed, 2 Dec 2015 14:21:38 +0100 [thread overview]
Message-ID: <20151202132138.GB22136@piout.net> (raw)
In-Reply-To: <20151201194919.GG5072-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On 01/12/2015 at 20:49:19 +0100, Uwe Kleine-König wrote :
> > Seeing the comment comment above, this should probably be if
> > (tm->tm_year < 100 || tm->tm_year >= 200)
> > I don't think this particular part has any issue
> > handling 2038. However, on 32bit platform, your userspace is probably
> > not ready to handle those date. hwclock should return the correct date.
>
> userspace is not ready because it cannot. Before this can be addressed,
> quite some things need fixing first. If I understood correctly timerfd
> for example is broken which completely locks up systemd.
>
> Note this doesn't justify to not write a date later than 2037 in the rtc
> driver however. Still thinking about how to handle this for the machines
> we work on, we thought about letting the RTC_RD_TIME ioctl fail for
> dates later than 2038 to work around this issue.
>
Yeah but the rtc doesn't have any issue handling dates after 2038 so if
it is used on a 64bit system, it can work properly until february 2100.
Also, I'm not sure how that solves your problem anyway.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-02 13:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:48 [rtc-linux] [PATCH v2 1/2] Documentation: devicetree: add epson rx6110 binding Steffen Trumtrar
2015-12-01 13:48 ` Steffen Trumtrar
2015-12-01 13:48 ` [rtc-linux] [PATCH v2 2/2] rtc: add driver for RX6110SA real time clock Steffen Trumtrar
2015-12-01 13:48 ` Steffen Trumtrar
2015-12-01 14:42 ` [rtc-linux] " Alexandre Belloni
2015-12-01 14:42 ` Alexandre Belloni
2015-12-01 19:49 ` [rtc-linux] " Uwe Kleine-König
2015-12-01 19:49 ` Uwe Kleine-König
2015-12-02 13:21 ` Alexandre Belloni [this message]
2015-12-02 13:21 ` Alexandre Belloni
2015-12-07 12:03 ` [rtc-linux] " Steffen Trumtrar
2015-12-07 12:03 ` Steffen Trumtrar
2015-12-03 14:55 ` [rtc-linux] Re: [PATCH v2 1/2] Documentation: devicetree: add epson rx6110 binding Rob Herring
2015-12-03 14:55 ` Rob Herring
2015-12-07 12:04 ` [rtc-linux] " Steffen Trumtrar
2015-12-07 12:04 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202132138.GB22136@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=s.trumtrar@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.