From: Ralf Baechle <ralf@linux-mips.org>
To: Yang Shi <yang.shi@linaro.org>
Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linaro-kernel@lists.linaro.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 4/7] mips: mm/gup: add gup trace points
Date: Wed, 2 Dec 2015 14:23:20 +0100 [thread overview]
Message-ID: <20151202132320.GA24730@linux-mips.org> (raw)
In-Reply-To: <1449011177-30686-5-git-send-email-yang.shi@linaro.org>
On Tue, Dec 01, 2015 at 03:06:14PM -0800, Yang Shi wrote:
> arch/mips/mm/gup.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/mips/mm/gup.c b/arch/mips/mm/gup.c
> index 349995d..3c5b8c8 100644
> --- a/arch/mips/mm/gup.c
> +++ b/arch/mips/mm/gup.c
> @@ -12,6 +12,9 @@
> #include <linux/swap.h>
> #include <linux/hugetlb.h>
>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/gup.h>
> +
> #include <asm/cpu-features.h>
> #include <asm/pgtable.h>
>
> @@ -211,6 +214,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> (void __user *)start, len)))
> return 0;
>
> + trace_gup_get_user_pages_fast(start, nr_pages, write, pages);
> +
> /*
> * XXX: batch / limit 'nr', to avoid large irq off latency
> * needs some instrumenting to determine the common sizes used by
> @@ -277,6 +282,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,
> if (end < start || cpu_has_dc_aliases)
> goto slow_irqon;
>
> + trace_gup_get_user_pages_fast(start, nr_pages, write, pages);
> +
> /* XXX: batch / limit 'nr' */
> local_irq_disable();
> pgdp = pgd_offset(mm, addr);
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Please feel free to merge this upstream with the remainder of the
series once it's been acked.
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Yang Shi <yang.shi@linaro.org>
Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linaro-kernel@lists.linaro.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 4/7] mips: mm/gup: add gup trace points
Date: Wed, 2 Dec 2015 14:23:20 +0100 [thread overview]
Message-ID: <20151202132320.GA24730@linux-mips.org> (raw)
In-Reply-To: <1449011177-30686-5-git-send-email-yang.shi@linaro.org>
On Tue, Dec 01, 2015 at 03:06:14PM -0800, Yang Shi wrote:
> arch/mips/mm/gup.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/mips/mm/gup.c b/arch/mips/mm/gup.c
> index 349995d..3c5b8c8 100644
> --- a/arch/mips/mm/gup.c
> +++ b/arch/mips/mm/gup.c
> @@ -12,6 +12,9 @@
> #include <linux/swap.h>
> #include <linux/hugetlb.h>
>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/gup.h>
> +
> #include <asm/cpu-features.h>
> #include <asm/pgtable.h>
>
> @@ -211,6 +214,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> (void __user *)start, len)))
> return 0;
>
> + trace_gup_get_user_pages_fast(start, nr_pages, write, pages);
> +
> /*
> * XXX: batch / limit 'nr', to avoid large irq off latency
> * needs some instrumenting to determine the common sizes used by
> @@ -277,6 +282,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,
> if (end < start || cpu_has_dc_aliases)
> goto slow_irqon;
>
> + trace_gup_get_user_pages_fast(start, nr_pages, write, pages);
> +
> /* XXX: batch / limit 'nr' */
> local_irq_disable();
> pgdp = pgd_offset(mm, addr);
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Please feel free to merge this upstream with the remainder of the
series once it's been acked.
Ralf
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-02 13:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 23:06 [RFC] Add gup trace points support Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:06 ` [PATCH 1/7] trace/events: Add gup trace events Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:56 ` Steven Rostedt
2015-12-01 23:56 ` Steven Rostedt
2015-12-02 0:07 ` Shi, Yang
2015-12-02 0:07 ` Shi, Yang
2015-12-02 0:18 ` Steven Rostedt
2015-12-02 0:18 ` Steven Rostedt
2015-12-02 0:39 ` Shi, Yang
2015-12-02 0:39 ` Shi, Yang
2015-12-01 23:06 ` [PATCH 2/7] mm/gup: add gup trace points Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:06 ` [PATCH 3/7] x86: " Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:06 ` [PATCH 4/7] mips: " Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-02 13:23 ` Ralf Baechle [this message]
2015-12-02 13:23 ` Ralf Baechle
2015-12-01 23:06 ` [PATCH 5/7] s390: " Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:06 ` [PATCH 6/7] sh: " Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:06 ` [PATCH 7/7] sparc64: " Yang Shi
2015-12-01 23:06 ` Yang Shi
2015-12-01 23:06 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202132320.GA24730@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.