All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Gang He <ghe@suse.com>
Cc: mfasheh@suse.com, rgoldwyn@suse.de, linux-kernel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, akpm@linux-foundation.org,
	Greg KH <greg@kroah.com>
Subject: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature
Date: Wed, 2 Dec 2015 19:20:12 +0100	[thread overview]
Message-ID: <20151202182012.GA21249@amd> (raw)
In-Reply-To: <1446013561-22121-1-git-send-email-ghe@suse.com>

On Wed 2015-10-28 14:25:57, Gang He wrote:
> When there are errors in the ocfs2 filesystem,
> they are usually accompanied by the inode number which caused the error.
> This inode number would be the input to fixing the file.
> One of these options could be considered:
> A file in the sys filesytem which would accept inode numbers.
> This could be used to communication back what has to be fixed or is fixed.
> You could write:
> $# echo "CHECK <inode>" > /sys/fs/ocfs2/devname/filecheck
> or
> $# echo "FIX <inode>" > /sys/fs/ocfs2/devname/filecheck
> 

Are you sure this is reasonable interface? I mean.... sysfs is
supposed to be one value per file. And I don't think its suitable for
running commands.

...or returning back results.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Gang He <ghe@suse.com>
Cc: mfasheh@suse.com, rgoldwyn@suse.de, linux-kernel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, akpm@linux-foundation.org,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH v2 0/4] Add online file check feature
Date: Wed, 2 Dec 2015 19:20:12 +0100	[thread overview]
Message-ID: <20151202182012.GA21249@amd> (raw)
In-Reply-To: <1446013561-22121-1-git-send-email-ghe@suse.com>

On Wed 2015-10-28 14:25:57, Gang He wrote:
> When there are errors in the ocfs2 filesystem,
> they are usually accompanied by the inode number which caused the error.
> This inode number would be the input to fixing the file.
> One of these options could be considered:
> A file in the sys filesytem which would accept inode numbers.
> This could be used to communication back what has to be fixed or is fixed.
> You could write:
> $# echo "CHECK <inode>" > /sys/fs/ocfs2/devname/filecheck
> or
> $# echo "FIX <inode>" > /sys/fs/ocfs2/devname/filecheck
> 

Are you sure this is reasonable interface? I mean.... sysfs is
supposed to be one value per file. And I don't think its suitable for
running commands.

...or returning back results.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2015-12-02 18:20 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  6:25 [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature Gang He
2015-10-28  6:25 ` Gang He
2015-10-28  6:25 ` [Ocfs2-devel] [PATCH v2 1/4] ocfs2: export ocfs2_kset for online file check Gang He
2015-10-28  6:25   ` Gang He
2015-11-24 21:47   ` [Ocfs2-devel] " Mark Fasheh
2015-11-24 21:47     ` Mark Fasheh
2015-10-28  6:25 ` [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces " Gang He
2015-10-28  6:25   ` Gang He
2015-11-03  7:20   ` [Ocfs2-devel] " Junxiao Bi
2015-11-03  7:20     ` Junxiao Bi
2015-11-03  7:54     ` [Ocfs2-devel] " Gang He
2015-11-03  7:54       ` Gang He
2015-11-03  8:20       ` [Ocfs2-devel] " Junxiao Bi
2015-11-03  8:20         ` Junxiao Bi
2015-11-03  8:30         ` [Ocfs2-devel] " Gang He
2015-11-03  8:30           ` Gang He
2015-11-24 21:46         ` [Ocfs2-devel] " Mark Fasheh
2015-11-24 21:46           ` Mark Fasheh
2015-11-24 21:55           ` [Ocfs2-devel] " Srinivas Eeda
2015-11-24 21:55             ` Srinivas Eeda
2015-11-25  3:29           ` Gang He
2015-11-25  3:29             ` Gang He
2015-11-25  4:43             ` [Ocfs2-devel] " Junxiao Bi
2015-11-25  4:43               ` Junxiao Bi
2015-11-25  5:11               ` [Ocfs2-devel] " Gang He
2015-11-25  5:11                 ` Gang He
2015-12-18 22:37             ` [Ocfs2-devel] " Mark Fasheh
2015-12-18 22:37               ` Mark Fasheh
2015-11-25  4:33           ` [Ocfs2-devel] " Junxiao Bi
2015-11-25  4:33             ` Junxiao Bi
2015-11-24 21:52   ` [Ocfs2-devel] " Mark Fasheh
2015-11-24 21:52     ` Mark Fasheh
2015-10-28  6:26 ` [Ocfs2-devel] [PATCH v2 3/4] ocfs2: create/remove sysfile " Gang He
2015-10-28  6:26   ` Gang He
2015-11-24 21:53   ` [Ocfs2-devel] " Mark Fasheh
2015-11-24 21:53     ` Mark Fasheh
2015-10-28  6:26 ` [Ocfs2-devel] [PATCH v2 4/4] ocfs2: check/fix inode block " Gang He
2015-10-28  6:26   ` Gang He
2015-11-03  7:12   ` [Ocfs2-devel] " Junxiao Bi
2015-11-03  7:12     ` Junxiao Bi
2015-11-03  8:15     ` [Ocfs2-devel] " Gang He
2015-11-03  8:15       ` Gang He
2015-11-03  8:29       ` [Ocfs2-devel] " Junxiao Bi
2015-11-03  8:29         ` Junxiao Bi
2015-11-03  8:47         ` [Ocfs2-devel] " Gang He
2015-11-03  8:47           ` Gang He
2015-11-03  9:01           ` [Ocfs2-devel] " Junxiao Bi
2015-11-03  9:01             ` Junxiao Bi
2015-11-03  9:25             ` [Ocfs2-devel] " Gang He
2015-11-03  9:25               ` Gang He
2015-11-24 22:16     ` [Ocfs2-devel] " Mark Fasheh
2015-11-24 22:16       ` Mark Fasheh
2015-11-25  4:11       ` Junxiao Bi
2015-11-25  4:11         ` Junxiao Bi
2015-11-25  5:04         ` Gang He
2015-11-25  5:04           ` Gang He
2015-11-25  5:44           ` Junxiao Bi
2015-11-25  5:44             ` Junxiao Bi
2015-10-28 16:34 ` [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature Srinivas Eeda
2015-10-28 16:34   ` Srinivas Eeda
2015-10-29  4:44   ` Gang He
2015-10-29  4:44     ` Gang He
2015-10-29  7:46     ` Srinivas Eeda
2015-10-29  7:46       ` Srinivas Eeda
2015-10-29  8:26       ` Gang He
2015-10-29  8:26         ` Gang He
2015-12-02 18:20 ` Pavel Machek [this message]
2015-12-02 18:20   ` Pavel Machek
2015-12-03  2:05   ` [Ocfs2-devel] " Gang He
2015-12-03  2:05     ` Gang He
2015-12-03  5:17     ` [Ocfs2-devel] " Greg KH
2015-12-03  5:17       ` Greg KH
2015-12-04  8:36       ` [Ocfs2-devel] " Gang He
2015-12-04  8:36         ` Gang He
2015-12-04  9:20         ` [Ocfs2-devel] " Pavel Machek
2015-12-04  9:20           ` Pavel Machek
2015-12-04 16:40         ` [Ocfs2-devel] " Greg KH
2015-12-04 16:40           ` Greg KH
2015-12-07  3:33           ` [Ocfs2-devel] " Gang He
2015-12-07  3:33             ` Gang He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202182012.GA21249@amd \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=ghe@suse.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rgoldwyn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.