From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: fix pinctrl driver selection
Date: Fri, 4 Dec 2015 18:53:57 +0100 [thread overview]
Message-ID: <20151204175357.GD3515@piout.net> (raw)
In-Reply-To: <5661CE71.5050206@arm.com>
On 04/12/2015 at 17:33:37 +0000, Sudeep Holla wrote :
>
>
> On 04/12/15 17:18, Alexandre Belloni wrote:
> >From: Ludovic Desroches <ludovic.desroches@atmel.com>
> >
> >Move the selection of the pinctrl driver to SoC family level since we
> >have two pinctrl drivers. It is useless to select one which is not
> >compatible with the SoC.
> >
> >[abelloni: fixed pm.c when only sama2d2 is selected]
> >Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> >Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >---
> > arch/arm/mach-at91/Kconfig | 6 +++++-
> > arch/arm/mach-at91/pm.c | 7 ++++++-
> > 2 files changed, 11 insertions(+), 2 deletions(-)
> >
>
> [...]
>
> >diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> >index 80e277cfcc8b..01cbb17e6f6b 100644
> >--- a/arch/arm/mach-at91/pm.c
> >+++ b/arch/arm/mach-at91/pm.c
> >@@ -41,8 +41,10 @@
> > * implementation should be moved down into the pinctrl driver and get
> > * called as part of the generic suspend/resume path.
> > */
> >+#ifdef PINCTRL_AT91
>
> Accidentally glanced at this patch when my mail client got hung at this
> patch :), I think you mean CONFIG_PINCTRL_AT91 here and later below.
>
Raah, sure. Thanks!
> --
> Regards,
> Sudeep
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: at91: fix pinctrl driver selection
Date: Fri, 4 Dec 2015 18:53:57 +0100 [thread overview]
Message-ID: <20151204175357.GD3515@piout.net> (raw)
In-Reply-To: <5661CE71.5050206@arm.com>
On 04/12/2015 at 17:33:37 +0000, Sudeep Holla wrote :
>
>
> On 04/12/15 17:18, Alexandre Belloni wrote:
> >From: Ludovic Desroches <ludovic.desroches@atmel.com>
> >
> >Move the selection of the pinctrl driver to SoC family level since we
> >have two pinctrl drivers. It is useless to select one which is not
> >compatible with the SoC.
> >
> >[abelloni: fixed pm.c when only sama2d2 is selected]
> >Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> >Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >---
> > arch/arm/mach-at91/Kconfig | 6 +++++-
> > arch/arm/mach-at91/pm.c | 7 ++++++-
> > 2 files changed, 11 insertions(+), 2 deletions(-)
> >
>
> [...]
>
> >diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> >index 80e277cfcc8b..01cbb17e6f6b 100644
> >--- a/arch/arm/mach-at91/pm.c
> >+++ b/arch/arm/mach-at91/pm.c
> >@@ -41,8 +41,10 @@
> > * implementation should be moved down into the pinctrl driver and get
> > * called as part of the generic suspend/resume path.
> > */
> >+#ifdef PINCTRL_AT91
>
> Accidentally glanced at this patch when my mail client got hung at this
> patch :), I think you mean CONFIG_PINCTRL_AT91 here and later below.
>
Raah, sure. Thanks!
> --
> Regards,
> Sudeep
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-04 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 17:18 [PATCH] ARM: at91: fix pinctrl driver selection Alexandre Belloni
2015-12-04 17:18 ` Alexandre Belloni
2015-12-04 17:33 ` Sudeep Holla
2015-12-04 17:33 ` Sudeep Holla
2015-12-04 17:53 ` Alexandre Belloni [this message]
2015-12-04 17:53 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2015-12-01 10:44 Ludovic Desroches
2015-12-01 10:44 ` Ludovic Desroches
2015-12-01 10:51 ` Nicolas Ferre
2015-12-01 10:51 ` Nicolas Ferre
2015-12-01 11:17 ` Alexandre Belloni
2015-12-01 11:17 ` Alexandre Belloni
2015-12-10 17:25 ` Linus Walleij
2015-12-10 17:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204175357.GD3515@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.