From: Venkatesh Srinivas via Virtualization <virtualization@lists.linux-foundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2] vhost: replace % with & on data path
Date: Fri, 4 Dec 2015 12:19:01 -0800 [thread overview]
Message-ID: <20151204201901.GB19430@google.com> (raw)
In-Reply-To: <1448874894-18398-1-git-send-email-mst@redhat.com>
On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote:
> We know vring num is a power of 2, so use &
> to mask the high bits.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
The generated code switches from DIV -> masking, source is clearer as well.
Tested-by: Venkatesh Srinivas <venkateshs@google.com>
-- vs;
WARNING: multiple messages have this Message-ID (diff)
From: Venkatesh Srinivas <venkateshs@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2] vhost: replace % with & on data path
Date: Fri, 4 Dec 2015 12:19:01 -0800 [thread overview]
Message-ID: <20151204201901.GB19430@google.com> (raw)
In-Reply-To: <1448874894-18398-1-git-send-email-mst@redhat.com>
On Mon, Nov 30, 2015 at 11:15:23AM +0200, Michael S. Tsirkin wrote:
> We know vring num is a power of 2, so use &
> to mask the high bits.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
The generated code switches from DIV -> masking, source is clearer as well.
Tested-by: Venkatesh Srinivas <venkateshs@google.com>
-- vs;
next prev parent reply other threads:[~2015-12-04 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 9:15 [PATCH v2] vhost: replace % with & on data path Michael S. Tsirkin
2015-11-30 9:15 ` Michael S. Tsirkin
2015-11-30 9:21 ` Christian Borntraeger
2015-11-30 9:21 ` Christian Borntraeger
2015-11-30 16:17 ` David Miller
2015-11-30 16:17 ` David Miller
2015-12-04 20:19 ` Venkatesh Srinivas via Virtualization [this message]
2015-12-04 20:19 ` Venkatesh Srinivas
2015-12-13 0:01 ` Andy Shevchenko
2015-12-13 0:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204201901.GB19430@google.com \
--to=virtualization@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.