From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] phy: berlin-usb: don't set device's driver_data
Date: Fri, 4 Dec 2015 22:09:19 +0100 [thread overview]
Message-ID: <20151204210919.GB7200@kwain> (raw)
In-Reply-To: <1449237421-5552-3-git-send-email-jszhang@marvell.com>
On Fri, Dec 04, 2015 at 09:57:01PM +0800, Jisheng Zhang wrote:
> After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and
> use it"), we get the address of priv by phy_get_drvdata(), so there's
> no need to set device's driver_data any more. This patch removes the
> call of platform_set_drvdata().
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/phy/phy-berlin-usb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 7bbb473..2017751 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -193,7 +193,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> return PTR_ERR(phy);
> }
>
> - platform_set_drvdata(pdev, priv);
> phy_set_drvdata(phy, priv);
>
> phy_provider =
> --
> 2.6.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151204/113bb1d5/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: kishon@ti.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] phy: berlin-usb: don't set device's driver_data
Date: Fri, 4 Dec 2015 22:09:19 +0100 [thread overview]
Message-ID: <20151204210919.GB7200@kwain> (raw)
In-Reply-To: <1449237421-5552-3-git-send-email-jszhang@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
On Fri, Dec 04, 2015 at 09:57:01PM +0800, Jisheng Zhang wrote:
> After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and
> use it"), we get the address of priv by phy_get_drvdata(), so there's
> no need to set device's driver_data any more. This patch removes the
> call of platform_set_drvdata().
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/phy/phy-berlin-usb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 7bbb473..2017751 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -193,7 +193,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> return PTR_ERR(phy);
> }
>
> - platform_set_drvdata(pdev, priv);
> phy_set_drvdata(phy, priv);
>
> phy_provider =
> --
> 2.6.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-04 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 13:56 [PATCH 0/2] phy: berlin-usb: clean up Jisheng Zhang
2015-12-04 13:56 ` Jisheng Zhang
2015-12-04 13:57 ` [PATCH 1/2] phy: berlin-usb: remove non-necessary header files Jisheng Zhang
2015-12-04 13:57 ` Jisheng Zhang
2015-12-04 21:08 ` Antoine Tenart
2015-12-04 21:08 ` Antoine Tenart
2015-12-04 13:57 ` [PATCH 2/2] phy: berlin-usb: don't set device's driver_data Jisheng Zhang
2015-12-04 13:57 ` Jisheng Zhang
2015-12-04 21:09 ` Antoine Tenart [this message]
2015-12-04 21:09 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204210919.GB7200@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.