From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: stm32-dma: Fix static checker warning
Date: Sat, 5 Dec 2015 13:51:42 +0530 [thread overview]
Message-ID: <20151205082142.GQ1854@localhost> (raw)
In-Reply-To: <1448355155-31283-1-git-send-email-cedric.madianga@gmail.com>
On Tue, Nov 24, 2015 at 09:52:35AM +0100, M'boumba Cedric Madianga wrote:
Title should say what is fixes rather than what flagged it off
> This patch fix an unchecked dereference warning by returning operation
> not permitted when stm32_dma_start_transfer() does not succeed to allocate
> a virtual channel descriptor.
>
Also we give credit to reported by using tag Reported-by: xxx, pls add that
as well
> Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
> ---
> drivers/dma/stm32-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
> index 12f3a3e..0214bcf 100644
> --- a/drivers/dma/stm32-dma.c
> +++ b/drivers/dma/stm32-dma.c
> @@ -437,7 +437,7 @@ static int stm32_dma_start_transfer(struct stm32_dma_chan *chan)
> if (!chan->desc) {
> vdesc = vchan_next_desc(&chan->vchan);
> if (!vdesc)
> - return 0;
> + return -EPERM;
>
> chan->desc = to_stm32_dma_desc(vdesc);
> chan->next_sg = 0;
> --
> 1.9.1
>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: "M'boumba Cedric Madianga" <cedric.madianga@gmail.com>
Cc: mcoquelin.stm32@gmail.com, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: stm32-dma: Fix static checker warning
Date: Sat, 5 Dec 2015 13:51:42 +0530 [thread overview]
Message-ID: <20151205082142.GQ1854@localhost> (raw)
In-Reply-To: <1448355155-31283-1-git-send-email-cedric.madianga@gmail.com>
On Tue, Nov 24, 2015 at 09:52:35AM +0100, M'boumba Cedric Madianga wrote:
Title should say what is fixes rather than what flagged it off
> This patch fix an unchecked dereference warning by returning operation
> not permitted when stm32_dma_start_transfer() does not succeed to allocate
> a virtual channel descriptor.
>
Also we give credit to reported by using tag Reported-by: xxx, pls add that
as well
> Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
> ---
> drivers/dma/stm32-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
> index 12f3a3e..0214bcf 100644
> --- a/drivers/dma/stm32-dma.c
> +++ b/drivers/dma/stm32-dma.c
> @@ -437,7 +437,7 @@ static int stm32_dma_start_transfer(struct stm32_dma_chan *chan)
> if (!chan->desc) {
> vdesc = vchan_next_desc(&chan->vchan);
> if (!vdesc)
> - return 0;
> + return -EPERM;
>
> chan->desc = to_stm32_dma_desc(vdesc);
> chan->next_sg = 0;
> --
> 1.9.1
>
--
~Vinod
next prev parent reply other threads:[~2015-12-05 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 8:52 [PATCH] dmaengine: stm32-dma: Fix static checker warning M'boumba Cedric Madianga
2015-11-24 8:52 ` M'boumba Cedric Madianga
2015-12-05 8:21 ` Vinod Koul [this message]
2015-12-05 8:21 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151205082142.GQ1854@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.