From: Viresh Kumar <viresh.kumar@linaro.org>
To: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Daniel Kurtz <djkurtz@chromium.org>,
linux-mediatek@lists.infradead.org,
linaro-kernel@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] cpufreq: mt8173: migrate to use operating-points-v2 bindings
Date: Mon, 7 Dec 2015 15:34:27 +0530 [thread overview]
Message-ID: <20151207100427.GG3294@ubuntu> (raw)
In-Reply-To: <1449305584-414-2-git-send-email-pi-cheng.chen@linaro.org>
On 05-12-15, 16:53, Pi-Cheng Chen wrote:
> diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c
> index 257bcb9..17e9cad 100644
> --- a/drivers/cpufreq/mt8173-cpufreq.c
> +++ b/drivers/cpufreq/mt8173-cpufreq.c
> @@ -344,6 +344,9 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> unsigned long rate;
> int ret;
>
> + /* Mark the first owner of this CPU DVFS domain information */
> + cpumask_set_cpu(cpu, &info->cpus);
> +
This is bad, sorry about that. Please update
dev_pm_opp_of_get_sharing_cpus() to update this as well.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] cpufreq: mt8173: migrate to use operating-points-v2 bindings
Date: Mon, 7 Dec 2015 15:34:27 +0530 [thread overview]
Message-ID: <20151207100427.GG3294@ubuntu> (raw)
In-Reply-To: <1449305584-414-2-git-send-email-pi-cheng.chen@linaro.org>
On 05-12-15, 16:53, Pi-Cheng Chen wrote:
> diff --git a/drivers/cpufreq/mt8173-cpufreq.c b/drivers/cpufreq/mt8173-cpufreq.c
> index 257bcb9..17e9cad 100644
> --- a/drivers/cpufreq/mt8173-cpufreq.c
> +++ b/drivers/cpufreq/mt8173-cpufreq.c
> @@ -344,6 +344,9 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> unsigned long rate;
> int ret;
>
> + /* Mark the first owner of this CPU DVFS domain information */
> + cpumask_set_cpu(cpu, &info->cpus);
> +
This is bad, sorry about that. Please update
dev_pm_opp_of_get_sharing_cpus() to update this as well.
--
viresh
next prev parent reply other threads:[~2015-12-07 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 8:53 [PATCH 0/2] ARM64: dts: cpufreq: mt8173: Migrate mt8173-cpufreq to use OPPv2 bindings Pi-Cheng Chen
2015-12-05 8:53 ` Pi-Cheng Chen
2015-12-05 8:53 ` [PATCH 1/2] cpufreq: mt8173: migrate to use operating-points-v2 bindings Pi-Cheng Chen
2015-12-05 8:53 ` Pi-Cheng Chen
2015-12-07 10:04 ` Viresh Kumar [this message]
2015-12-07 10:04 ` Viresh Kumar
2015-12-07 12:43 ` Pi-Cheng Chen
2015-12-07 12:43 ` Pi-Cheng Chen
2015-12-05 8:53 ` [PATCH 2/2] ARM64: dts: mt8173: Add CPU OPP, clock and regulator supply properties Pi-Cheng Chen
2015-12-05 8:53 ` Pi-Cheng Chen
2015-12-07 10:07 ` Viresh Kumar
2015-12-07 10:07 ` Viresh Kumar
2015-12-07 12:44 ` Pi-Cheng Chen
2015-12-07 12:44 ` Pi-Cheng Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207100427.GG3294@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pi-cheng.chen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.