From: Mike Snitzer <snitzer@redhat.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
Mandeep Baines <msb@chromium.org>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
Mikulas Patocka <mpatocka@redhat.com>,
Mark Salyzyn <salyzyn@google.com>,
Alasdair Kergon <agk@redhat.com>, Milan Broz <mbroz@redhat.com>
Subject: Re: [PATCH v2 0/2] dm verity: add support for error correction
Date: Mon, 7 Dec 2015 09:58:14 -0500 [thread overview]
Message-ID: <20151207145814.GB29457@redhat.com> (raw)
In-Reply-To: <20151207132149.GA7583@google.com>
On Mon, Dec 07 2015 at 8:21am -0500,
Sami Tolvanen <samitolvanen@google.com> wrote:
> On Fri, Dec 04, 2015 at 04:09:35PM -0500, Mike Snitzer wrote:
> > I'd really appreciate it if you could do some regression testing,
> > etc on your end to verify I didn't break anything while tweaking
> > things.
>
> Sure. The changes look fine. I applied them to my tree and everything
> still works as expected in my tests.
Great. Moving forward it'd be awesome if you could work to get your
verity FEC support regression tests into cryptsetup's tests. We need a
way to verify future DM and/or other kernel changes don't somehow cause
this FEC support to regress.
Also, I know you said you'd be getting Milan a veritysetup patch soon.
How are things going on that? Ideally that'll land in conjunction with
the kernel's dm-verity FEC support.
> Thanks for taking the time to review the patches!
No problem, like I said I'll be reviewing the code further but at this
point your changes seem to be on-track for upstream Linux 4.5
inclusion.
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Mandeep Baines <msb@chromium.org>, Will Drewry <wad@chromium.org>,
Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
Mark Salyzyn <salyzyn@google.com>, Milan Broz <mbroz@redhat.com>
Subject: Re: [PATCH v2 0/2] dm verity: add support for error correction
Date: Mon, 7 Dec 2015 09:58:14 -0500 [thread overview]
Message-ID: <20151207145814.GB29457@redhat.com> (raw)
In-Reply-To: <20151207132149.GA7583@google.com>
On Mon, Dec 07 2015 at 8:21am -0500,
Sami Tolvanen <samitolvanen@google.com> wrote:
> On Fri, Dec 04, 2015 at 04:09:35PM -0500, Mike Snitzer wrote:
> > I'd really appreciate it if you could do some regression testing,
> > etc on your end to verify I didn't break anything while tweaking
> > things.
>
> Sure. The changes look fine. I applied them to my tree and everything
> still works as expected in my tests.
Great. Moving forward it'd be awesome if you could work to get your
verity FEC support regression tests into cryptsetup's tests. We need a
way to verify future DM and/or other kernel changes don't somehow cause
this FEC support to regress.
Also, I know you said you'd be getting Milan a veritysetup patch soon.
How are things going on that? Ideally that'll land in conjunction with
the kernel's dm-verity FEC support.
> Thanks for taking the time to review the patches!
No problem, like I said I'll be reviewing the code further but at this
point your changes seem to be on-track for upstream Linux 4.5
inclusion.
Mike
next prev parent reply other threads:[~2015-12-07 14:58 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 2:02 [PATCH 0/4] dm verity: add support for error correction Sami Tolvanen
2015-11-05 2:02 ` Sami Tolvanen
2015-11-05 2:02 ` [PATCH 1/4] dm verity: clean up duplicate hashing code Sami Tolvanen
2015-11-17 22:32 ` Kees Cook
2015-11-05 2:02 ` [PATCH 2/4] dm verity: separate function for parsing opt args Sami Tolvanen
2015-11-05 2:02 ` Sami Tolvanen
2015-11-17 22:33 ` Kees Cook
2015-12-02 20:16 ` Mike Snitzer
2015-11-05 2:02 ` [PATCH 3/4] dm verity: add support for forward error correction Sami Tolvanen
2015-11-05 5:36 ` kbuild test robot
2015-11-05 5:36 ` kbuild test robot
2015-11-05 22:06 ` kbuild test robot
2015-11-05 22:06 ` kbuild test robot
2015-11-05 2:02 ` [PATCH 4/4] dm verity: ignore zero blocks Sami Tolvanen
2015-11-05 22:13 ` kbuild test robot
2015-11-05 22:13 ` kbuild test robot
2015-11-05 7:34 ` [PATCH 0/4] dm verity: add support for error correction Milan Broz
2015-11-05 17:33 ` Sami Tolvanen
2015-11-09 16:37 ` Mike Snitzer
2015-11-09 19:19 ` Sami Tolvanen
2015-11-09 19:58 ` Mike Snitzer
2015-11-12 10:30 ` Milan Broz
2015-12-03 9:36 ` Sami Tolvanen
2015-11-12 18:50 ` Mikulas Patocka
2015-12-03 9:33 ` Sami Tolvanen
2015-12-02 20:22 ` Mike Snitzer
2015-12-03 9:11 ` Sami Tolvanen
2015-11-06 17:23 ` Mikulas Patocka
2015-11-06 19:06 ` Sami Tolvanen
2015-11-06 19:20 ` [dm-devel] " Zdenek Kabelac
2015-11-06 20:27 ` Sami Tolvanen
2015-11-06 21:05 ` Zdenek Kabelac
2015-11-06 21:23 ` Sami Tolvanen
2015-11-07 15:29 ` Mikulas Patocka
2015-11-07 15:20 ` Mikulas Patocka
2015-11-07 15:18 ` Mikulas Patocka
2015-11-09 15:06 ` Austin S Hemmelgarn
2015-12-03 14:26 ` [PATCH v2 0/2] " Sami Tolvanen
2015-12-03 14:26 ` [PATCH v2 1/2] dm verity: add support for forward " Sami Tolvanen
2015-12-03 14:26 ` [PATCH v2 2/2] dm verity: ignore zero blocks Sami Tolvanen
2015-12-03 19:54 ` [PATCH v2 0/2] dm verity: add support for error correction Mike Snitzer
2015-12-03 23:05 ` Mike Snitzer
2015-12-04 10:03 ` Sami Tolvanen
2015-12-04 21:09 ` Mike Snitzer
2015-12-07 13:21 ` Sami Tolvanen
2015-12-07 14:58 ` Mike Snitzer [this message]
2015-12-07 14:58 ` Mike Snitzer
2015-12-07 16:31 ` Sami Tolvanen
2015-12-07 18:07 ` Milan Broz
2015-12-07 19:07 ` Mike Snitzer
2015-12-08 10:18 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207145814.GB29457@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mpatocka@redhat.com \
--cc=msb@chromium.org \
--cc=salyzyn@google.com \
--cc=samitolvanen@google.com \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.