From: David Gibson <david@gibson.dropbear.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
Alexander Graf <agraf@suse.com>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH kernel 2/9] KVM: PPC: Make real_vmalloc_addr() public
Date: Tue, 08 Dec 2015 02:08:03 +0000 [thread overview]
Message-ID: <20151208020803.GH20139@voom.fritz.box> (raw)
In-Reply-To: <1442314179-9706-3-git-send-email-aik@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Tue, Sep 15, 2015 at 08:49:32PM +1000, Alexey Kardashevskiy wrote:
> This helper translates vmalloc'd addresses to linear addresses.
> It is only used by the KVM MMU code now and resides in the HV KVM code.
> We will need it further in the TCE code and the DMA memory preregistration
> code called in real mode.
>
> This makes real_vmalloc_addr() public and moves it to the powerpc code as
> it does not do anything special for KVM.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Hmm, I have a couple of small concerns.
First, I'm not sure if the name is clear enough for a public function.
Second, I'm not sure if mmu-hash64.h is the right place for it. This
is still a function with very specific and limited usage, I wonder if
we should have somewhere else for such special real mode helpers.
Paulus, thoughts?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
Alexander Graf <agraf@suse.com>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH kernel 2/9] KVM: PPC: Make real_vmalloc_addr() public
Date: Tue, 8 Dec 2015 13:08:03 +1100 [thread overview]
Message-ID: <20151208020803.GH20139@voom.fritz.box> (raw)
In-Reply-To: <1442314179-9706-3-git-send-email-aik@ozlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Tue, Sep 15, 2015 at 08:49:32PM +1000, Alexey Kardashevskiy wrote:
> This helper translates vmalloc'd addresses to linear addresses.
> It is only used by the KVM MMU code now and resides in the HV KVM code.
> We will need it further in the TCE code and the DMA memory preregistration
> code called in real mode.
>
> This makes real_vmalloc_addr() public and moves it to the powerpc code as
> it does not do anything special for KVM.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Hmm, I have a couple of small concerns.
First, I'm not sure if the name is clear enough for a public function.
Second, I'm not sure if mmu-hash64.h is the right place for it. This
is still a function with very specific and limited usage, I wonder if
we should have somewhere else for such special real mode helpers.
Paulus, thoughts?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-08 2:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 10:49 [PATCH kernel 0/9] KVM: PPC: Add in-kernel multitce handling Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-09-15 10:49 ` [PATCH kernel 1/9] rcu: Define notrace version of list_for_each_entry_rcu Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 2:05 ` David Gibson
2015-12-08 2:05 ` David Gibson
2015-09-15 10:49 ` [PATCH kernel 2/9] KVM: PPC: Make real_vmalloc_addr() public Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 2:08 ` David Gibson [this message]
2015-12-08 2:08 ` David Gibson
2015-09-15 10:49 ` [PATCH kernel 3/9] KVM: PPC: Rework H_PUT_TCE/H_GET_TCE handlers Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 2:18 ` David Gibson
2015-12-08 2:18 ` David Gibson
2015-09-15 10:49 ` [PATCH kernel 4/9] KVM: PPC: Use RCU for arch.spapr_tce_tables Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 2:35 ` David Gibson
2015-12-08 2:35 ` David Gibson
2015-09-15 10:49 ` [PATCH kernel 5/9] KVM: PPC: Account TCE-containing pages in locked_vm Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-11-30 2:06 ` Paul Mackerras
2015-11-30 2:06 ` Paul Mackerras
2015-11-30 5:09 ` Alexey Kardashevskiy
2015-11-30 5:09 ` Alexey Kardashevskiy
2015-12-08 5:18 ` David Gibson
2015-12-08 5:18 ` David Gibson
2015-09-15 10:49 ` [PATCH kernel 6/9] KVM: PPC: Replace SPAPR_TCE_SHIFT with IOMMU_PAGE_SHIFT_4K Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 5:19 ` David Gibson
2015-12-08 5:19 ` David Gibson
2015-09-15 10:49 ` [PATCH kernel 7/9] KVM: PPC: Move reusable bits of H_PUT_TCE handler to helpers Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 5:27 ` David Gibson
2015-12-08 5:27 ` David Gibson
2015-12-22 7:24 ` Alexey Kardashevskiy
2015-12-22 7:24 ` Alexey Kardashevskiy
2015-09-15 10:49 ` [PATCH kernel 8/9] KVM: Fix KVM_SMI chapter number Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 5:29 ` David Gibson
2015-12-08 5:29 ` David Gibson
2015-09-15 10:49 ` [PATCH kernel 9/9] KVM: PPC: Add support for multiple-TCE hcalls Alexey Kardashevskiy
2015-09-15 10:49 ` Alexey Kardashevskiy
2015-12-08 5:48 ` David Gibson
2015-12-08 5:48 ` David Gibson
2015-12-22 7:42 ` Alexey Kardashevskiy
2015-12-22 7:42 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208020803.GH20139@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.com \
--cc=aik@ozlabs.ru \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.