Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto
	<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Yoshihiro Shimoda
	<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string
Date: Tue, 08 Dec 2015 07:49:40 +0000	[thread overview]
Message-ID: <20151208074932.GA5663@verge.net.au> (raw)
In-Reply-To: <87egex5vfl.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

On Tue, Dec 08, 2015 at 06:05:51AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > Add fallback compatibility string.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> (snip)
> > +	{
> > +		.compatible = "renesas,usbhs",
> > +		.data = (void *)USBHS_TYPE_RCAR_GEN2,
> > +	},
> >  	{ },
> >  };
> 
> I think this is too much. This driver is used not only from R-Car Gen2.
> It will work as normal mode if .data was 0.
> see usbhs_parse_dt()

Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver?

WARNING: multiple messages have this Message-ID (diff)

From: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
To: Kuninori Morimoto
	<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Yoshihiro Shimoda
	<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string
Date: Tue, 8 Dec 2015 16:49:40 +0900	[thread overview]
Message-ID: <20151208074932.GA5663@verge.net.au> (raw)
In-Reply-To: <87egex5vfl.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

On Tue, Dec 08, 2015 at 06:05:51AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > Add fallback compatibility string.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> > 
> > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
> > ---
> (snip)
> > +	{
> > +		.compatible = "renesas,usbhs",
> > +		.data = (void *)USBHS_TYPE_RCAR_GEN2,
> > +	},
> >  	{ },
> >  };
> 
> I think this is too much. This driver is used not only from R-Car Gen2.
> It will work as normal mode if .data was 0.
> see usbhs_parse_dt()

Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

next prev parent reply	other threads:[~2015-12-08  7:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08  5:51 [PATCH 0/2] usb: renesas_usbhs: More compat strings Simon Horman
2015-12-08  5:51 ` Simon Horman
     [not found] ` <1449553911-21412-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-08  5:51   ` [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string Simon Horman
2015-12-08  5:51     ` Simon Horman
     [not found]     ` <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-08  6:05       ` Kuninori Morimoto
2015-12-08  6:05         ` Kuninori Morimoto
     [not found]         ` <87egex5vfl.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2015-12-08  7:49           ` Simon Horman [this message]
2015-12-08  7:49             ` Simon Horman
2015-12-08  8:32             ` Kuninori Morimoto
2015-12-08  8:32               ` Kuninori Morimoto
     [not found]               ` <87a8pl5oms.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2015-12-09  2:37                 ` Simon Horman
2015-12-09  2:37                   ` Simon Horman
2015-12-09  4:48                   ` Kuninori Morimoto
2015-12-09  4:48                     ` Kuninori Morimoto
2015-12-09  5:30                     ` Simon Horman
2015-12-09  5:30                       ` Simon Horman
     [not found]                       ` <20151209052957.GA20831-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-09  6:29                         ` Kuninori Morimoto
2015-12-09  6:29                           ` Kuninori Morimoto
2015-12-09  6:42                           ` Simon Horman
2015-12-09  6:42                             ` Simon Horman
2015-12-08 14:35       ` Sergei Shtylyov
2015-12-08 14:35         ` Sergei Shtylyov
     [not found]         ` <5666EAB0.6000109-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-12-09  2:37           ` Simon Horman
2015-12-09  2:37             ` Simon Horman
2015-12-08  5:51 ` [PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] Simon Horman
2015-12-08  5:51   ` Simon Horman
     [not found]   ` <1449553911-21412-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-09  3:29     ` Rob Herring
2015-12-09  3:29       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151208074932.GA5663@verge.net.au \
    --to=horms@verge.net.au \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.