From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joonsoo Kim <js1304@gmail.com>, Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32
Date: Tue, 8 Dec 2015 09:45:46 +0000 [thread overview]
Message-ID: <20151208094546.GD19677@suse.de> (raw)
In-Reply-To: <20151207170041.c470d362915ae1b42a8a4ef8@linux-foundation.org>
On Mon, Dec 07, 2015 at 05:00:41PM -0800, Andrew Morton wrote:
> On Thu, 3 Dec 2015 13:11:40 +0900 Joonsoo Kim <js1304@gmail.com> wrote:
>
> > Until now, COMPACT_CLUSTER_MAX is defined as SWAP_CLUSTER_MAX.
> > Commit ("mm: increase SWAP_CLUSTER_MAX to batch TLB flushes")
> > changes SWAP_CLUSTER_MAX from 32 to 256 to improve tlb flush performance
> > so COMPACT_CLUSTER_MAX is also changed to 256.
>
> "mm: increase SWAP_CLUSTER_MAX to batch TLB flushes" has been in limbo
> for quite a while. Because it has been unclear whether the patch's
> benefits exceed its costs+risks.
>
> We should make a decision here - either do the appropriate testing or
> drop the patch.
>
At this point, drop it. The benefits that apply to some corner cases are
marginal but the concerns about potentially isolating and reclaiming too
much persist.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joonsoo Kim <js1304@gmail.com>, Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32
Date: Tue, 8 Dec 2015 09:45:46 +0000 [thread overview]
Message-ID: <20151208094546.GD19677@suse.de> (raw)
In-Reply-To: <20151207170041.c470d362915ae1b42a8a4ef8@linux-foundation.org>
On Mon, Dec 07, 2015 at 05:00:41PM -0800, Andrew Morton wrote:
> On Thu, 3 Dec 2015 13:11:40 +0900 Joonsoo Kim <js1304@gmail.com> wrote:
>
> > Until now, COMPACT_CLUSTER_MAX is defined as SWAP_CLUSTER_MAX.
> > Commit ("mm: increase SWAP_CLUSTER_MAX to batch TLB flushes")
> > changes SWAP_CLUSTER_MAX from 32 to 256 to improve tlb flush performance
> > so COMPACT_CLUSTER_MAX is also changed to 256.
>
> "mm: increase SWAP_CLUSTER_MAX to batch TLB flushes" has been in limbo
> for quite a while. Because it has been unclear whether the patch's
> benefits exceed its costs+risks.
>
> We should make a decision here - either do the appropriate testing or
> drop the patch.
>
At this point, drop it. The benefits that apply to some corner cases are
marginal but the concerns about potentially isolating and reclaiming too
much persist.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2015-12-08 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 4:11 [PATCH] mm/compaction: restore COMPACT_CLUSTER_MAX to 32 Joonsoo Kim
2015-12-03 4:11 ` Joonsoo Kim
2015-12-08 1:00 ` Andrew Morton
2015-12-08 1:00 ` Andrew Morton
2015-12-08 9:45 ` Mel Gorman [this message]
2015-12-08 9:45 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208094546.GD19677@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.