All of lore.kernel.org
 help / color / mirror / Atom feed
From: "wen.pu@powercore.com.cn" <wen.pu@powercore.com.cn>
To: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type
Date: Tue, 8 Dec 2015 15:30:13 +0800	[thread overview]
Message-ID: <20151208153012239673106@powercore.com.cn> (raw)

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

I found that there are unimplemented OPAL message types "OPAL_MSG_EPOW" and 
"OPAL_MSG_DPO" in PowerNV Platform. If skiboot send such messages to kernel, 
nothing will happen(notifier_call_chain() will silently drop it). So I add a warning 
to inform what has happened, is it necessary? 

Signed-off-by: Wen Pu <wen.pu@powercore.com.cn>
---
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index f084afa..ef498ab 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -281,6 +281,10 @@ static void opal_handle_message(void)
  pr_warning("%s: Unknown message type: %u\n", __func__, type);
  return;
  }
+ if(type == OPAL_MSG_EPOW || type == OPAL_MSG_DPO) {
+ pr_warning("%s: Unimplemented message type: %u\n", __func__, type);
+ return;
+ }
  opal_message_do_notify(type, (void *)&msg);
 }
---

Thanks!
Wen Pu

[-- Attachment #2: Type: text/html, Size: 3212 bytes --]

             reply	other threads:[~2015-12-08  7:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08  7:30 wen.pu [this message]
2015-12-09  0:17 ` [PATCH] powerpc/opal: add warning for unimplemented OPAL message type Michael Ellerman
2015-12-09  8:56   ` Wen Pu
  -- strict thread matches above, loose matches on Subject: below --
2015-12-09  8:55 蒲文
2015-12-11  0:51 ` Stewart Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151208153012239673106@powercore.com.cn \
    --to=wen.pu@powercore.com.cn \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.